Build: Use jquery-git in place of jquery-compat-git

[mgol]

jQuery Compat is not going to get released after all; jQuery UI should be tested
against jquery-git instead of jquery-compat-git.

---

Should I report a ticket about that? cc @scottgonzalez @jzaefferer

Once it's ready to get merged, please notify me so that I update the Jenkins setup to use the git version instead of compat-git.

[scottgonzalez]

No need for a ticket. What are the supported browsers?

[mgol]

What are the supported browsers?

• Desktop
  • Chrome: (Current - 1) and Current
  • Edge: Current
  • Firefox: (Current - 1) and Current
  • Internet Explorer: 9+
  • Safari: (Current - 1) and Current
  • Opera: Current
  • Yandex.Browser: Current
• Mobile
  • Android: 4.0+ (plus limited 2.3 support)
  • iOS: 7+

[mgol]

Right, so the problem will be you're testing on IE8, it would require using a different browser set for the git part...

[mgol]

I'd go with the way jQuery TestSwarm is configured (by accepting externally passed browserSets parameter) and creating a new jquery-ui+jquery-git browser set that would be jquery-ui minus browsers not supported by jQuery Git (currently just IE 8).

Does that sound OK?

EDIT: Or maybe jquery-ui+jquery-3 instead of jquery-ui+jquery-git as this will need to be used more than just for the Git version once jQuery 3 gets released.

[scottgonzalez]

Yup. And we already use configured browser sets:

jquery-ui/build/tasks/testswarm.js

Line 63 in 0cc197a

browserSets: config.browserSets,

[mgol]

@scottgonzalez These are the browserSets from the JSON config on the TestSwarm server. Core uses it by default (look at the exact line I linked to) but allows to provide a browserSet name as a parameter to the testswarm Grunt task, this is required since the "UI + Core Git" job will need a different browserSet. So IMO a modification is still needed.

[mgol]

@scottgonzalez I submitted PR #1648; this is a pre-requisite to make this one work. PTAL.

[mgol]

PR updated. I modified the Jenkins jobs so that they use the git Core version so after merging this PR tests should run correctly.

[scottgonzalez]

Thanks @mzgol! This looks good to me, but I'd like to have @jzaefferer chime in as well before merging.

[mgol]

I'd like to have @jzaefferer chime in as well before merging.

Should I disable the "jQuery UI - git core" Jenkins job until he approves it? It will currently fail as it now looks for the "git" key which is not present in the versions variable.

[scottgonzalez]

You can, but if we end up with one or two failures in the meantime, I don't think anyone will be alarmed :-)

[mgol]

OK, fine. :) I'll wait then.

[jzaefferer]

Looks good to me.