Skip to content

Build: Allow to pass custom browserSets to the testswarm* tasks #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgol
Copy link
Member

@mgol mgol commented Nov 13, 2015

This is needed to be able to test UI with Core Git that doesn't support IE 8.

Ref gh-1646

This is needed to be able to test UI with Core Git that doesn't support IE 8.

Ref jquerygh-1646
@scottgonzalez
Copy link
Member

Can we just manage the browser set for git in the task directly? I'd prefer having that logic contained in the task instead of having to manage the external build settings.

@mgol
Copy link
Member Author

mgol commented Nov 13, 2015

We can but it will be spread anyway as a browserSet with this name has to be defined in the infrastructure repository. Also, as new jQuery versions may drop further browsers, you may end up needing to hardcode more than one browserSet and keep it in sync with the infra repo.

Do you want me hardcode the browserSet for Core Git? Is the name jquery-ui+jquery-3 OK? The regular UI browserSet is named jquery-ui.

@scottgonzalez
Copy link
Member

We can but it will be spread anyway as a browserSet with this name has to be defined in the infrastructure repository.

That's fine. Creating the browser set will be a one time thing. I don't see this expanding to more and more sets.

Also, as new jQuery versions may drop further browsers, you may end up needing to hardcode more than one browserSet and keep it in sync with the infra repo.

I don't think we'd ever want to handle many browser sets. To be honest, I wouldn't be surprised to see this entire thing go away in just a few months.

@scottgonzalez
Copy link
Member

Do you want me hardcode the browserSet for Core Git?

Yes, please.

Is the name jquery-ui+jquery-3 OK? The regular UI browserSet is named jquery-ui.

Let's just use jquery-ui-future.

@mgol
Copy link
Member Author

mgol commented Nov 13, 2015

Let's just use jquery-ui-future.

OK, I'll do it. I'll just note that when we release jQuery 3.0.0 in a few months, jquery-ui-future will have to be used for that as well.

@mgol
Copy link
Member Author

mgol commented Nov 13, 2015

I'm closing this PR; everything can be handled directly in #1646.

@mgol mgol closed this Nov 13, 2015
@mgol mgol deleted the custom-browserSet branch November 13, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants