Add jQuery 1.12/2.2 to the test configuration + minor updates #1706

mgol · 2016-05-25T13:02:56Z

I've noticed jQuery 1.12/2.2 are not currently tested; I added proper config. Once this lands I can create a new Jenkins job for UI + Core 1.12.

I have a few questions:

Are there any plans to test against jQuery Core 2.x? While they're supposed to be API-compatible with 1.x counterparts the internal code is different so they may be subtle bugs. It seems weird to me to test all 4 patch releases of 1.11.x but not to test even one 2.1.x.
What's the purpose of the jquery-1.x entry in bower.json & in the external directory?

I've also added a few improvements to build-related stuff in the followup commits.

scottgonzalez · 2016-05-25T13:15:16Z

Are there any plans to test against jQuery Core 2.x? While they're supposed to be API-compatible with 1.x counterparts the internal code is different so they may be subtle bugs.

We have the ability to test locally, but we don't test against 2.x in CI. This was done so long ago, I honestly don't remember the reasoning. I can't think of any problems with adding it, we'll just need to use different browser sets.

It seems weird to me to test all 4 patch releases of 1.11.x but not to test even one 2.1.x.

Re: all 4 patch releases; we'll probably never test against only the latest patch version because that's just not how developers actually work.

Re: 2.1.x; As I said above, I'm ok with adding this now.

scottgonzalez · 2016-05-25T13:16:00Z

What's the purpose of the jquery-1.x entry in bower.json & in the external directory?

I'm not sure what you're asking. Are you asking why we have all the 1.x versions? It's because we support them. Are you asking why they're in external? It's because we don't use bower_components.

scottgonzalez · 2016-05-25T13:19:50Z

package.json

 		"commitplease": "2.3.0",
 		"grunt": "0.4.5",
 		"grunt-bowercopy": "1.2.4",
+		"grunt-cli": "0.1.13",


I'm not really a fan of this change. It breaks the standard usage of Grunt.

How does it break it? You can still use the global grunt-cli if you wish so. OTH:

In development all the dependencies are fixed so the possibility of a breakage is decreased.

npm scripts can use the grunt binary without any global installation.

People that don't like global packages may not use them here. Without including grunt-cli it's simply not possible as the grunt package doesn't contain any binary to run.

Most of the projects I contribute to include grunt-cli in devDependencies for these reasons. I often don't even have grunt-cli installed globally until I encounter a project that doesn't include this.

It seems to me that including it as a dependency doesn't break the usage for people that don't want to rely on it but not including it breaks the usage for others.

Even the grunt-cli README mentions this pattern so I don't understand your comment.

Ok, let's leave this change.

mgol · 2016-05-25T13:44:46Z

We have the ability to test locally, but we don't test against 2.x in CI. This was done so long ago, I honestly don't remember the reasoning.

I see. From what I remember the browser set used for testing was hardcoded in the UI repo but now different jobs can use different browser sets (I did it so that UI could be tested against jQuery 3.0.0 WIP) so this can be done. I can update this PR & create proper Jenkins jobs or 2.0, 2.1 & 2.2.

I'm not sure what you're asking. Are you asking why we have all the 1.x versions?

No, I'm asking about this entry in bower.json and this in the bowercopy config.

scottgonzalez · 2016-05-25T14:02:06Z

I can update this PR & create proper Jenkins jobs or 2.0, 2.1 & 2.2.

Sounds good.

No, I'm asking about this entry in bower.json and this in the bowercopy config.

As I said, we don't use bower_components. bower.json only exists for the bowercopy task. The only files we care about live in external.

scottgonzalez · 2016-05-25T14:04:37Z

Oh, sorry. Let me explain the 1.x entry. We need a single reference to jQuery for use in demos. To do that, we use 1.x and copy it to a file that doesn't have a version. This allows us to not have to update a ton of references when we change the latest version we're testing against.

mgol · 2016-05-25T14:05:09Z

@scottgonzalez Thanks for the explanation!

scottgonzalez · 2016-05-25T14:06:09Z

bower.json

+		"jquery-1.12.2": "jquery#1.12.2",
+		"jquery-1.12.3": "jquery#1.12.3",
+		"jquery-1.12.4": "jquery#1.12.4",
 		"jquery-1.x": "jquery#1.11.3",


Thanks for pointing this out in your comment (and sorry for taking so long to understand what you were asking). This should be updated to point to 1.12.4; it always tracks the latest 1.x version, and then it gets used in demos and some other places.

Changed. I also changed it at

jquery-ui/tests/lib/bootstrap.js

Line 99 in fbc79e1

url = "../../../external/jquery-" + ( version || "1.11.3" ) + "/jquery";

This makes it possible to use Grunt without installing grunt-cli globally which makes the whole process more resilient.

mgol · 2016-05-25T14:15:32Z

PR updated.

scottgonzalez · 2016-05-25T19:44:48Z

This looks good. Is this ready to be merged or do you still need to make changes in Jenkins first?

mgol · 2016-05-25T20:35:22Z

do you still need to make changes in Jenkins first

I've just created the Jenkins jobs for 1.12, 2.0, 2.1 & 2.2. I also added another commit to this PR that makes only Core 1.x jobs to be tested on IE 8, PTAL.

If this looks fine, feel free to merge. I'll then check if I configured the Jenkins jobs correctly.

Ref gh-1706

This makes it possible to use Grunt without installing grunt-cli globally which makes the whole process more resilient. Ref gh-1706

scottgonzalez · 2016-05-25T20:42:59Z

Merged.

mgol · 2016-05-25T23:41:32Z

I've triggered the jobs manually and they seem to be running correctly:

A couple of tests are consistently failing with 2.0.0-2.0.3 in all browsers.

jQuery 2.0.3 fixed very few things from 2.0.2, the list is here: http://blog.jquery.com/2013/07/03/jquery-1-10-2-and-2-0-3-released/ One of the fixes was http://bugs.jquery.com/ticket/13980, though which was about cross-domain iframe issues. The problem is TestSwarm loads a cross-domain iframe: the main page is swarm.jquery.org, the frame is on builds.jenkins.jquery.com so it might be causing issues. You can see jQuery UI tests are timing out in all IE versions in jQuery 2.0.2: http://swarm.jquery.org/job/2918 The problem is that it doesn't just fail, it starves the available IE pool, making it sometimes harder for other projects to get their tests run on IE. That's why tests with jQuery 2.0.2 on TestSwarm need to be removed as it's been done with 1.10.1. Refs #12745 Refs c2224bf Refs jquerygh-1706

mgol · 2016-05-26T09:43:04Z

OK, Core 2.0.2 is completely unusable on TestSwarm, it drains the available IE pool & needs to be removed as 1.10.1 has for the same reason. See PR #1707 for more details.

jQuery 2.0.3 fixed very few things from 2.0.2, the list is here: http://blog.jquery.com/2013/07/03/jquery-1-10-2-and-2-0-3-released/ One of the fixes was http://bugs.jquery.com/ticket/13980, though which was about cross-domain iframe issues. The problem is TestSwarm loads a cross-domain iframe: the main page is swarm.jquery.org, the frame is on builds.jenkins.jquery.com so it might be causing issues. You can see jQuery UI tests are timing out in all IE versions in jQuery 2.0.2: http://swarm.jquery.org/job/2918 The problem is that it doesn't just fail, it starves the available IE pool, making it sometimes harder for other projects to get their tests run on IE. That's why tests with jQuery 2.0.2 on TestSwarm need to be removed as it's been done with 1.10.1. Refs #12745 Refs c2224bf Refs gh-1706 Closes gh-1707

jquerybot added the CLA: Valid label May 25, 2016

scottgonzalez reviewed May 25, 2016
View reviewed changes

mgol added 3 commits May 25, 2016 16:13

Build: Add jQuery 1.12/2.2 to the test configuration

70cd44b

Build: Add bower_components to .gitignore

69e6fa9

Build: Add grunt-cli to devDependencies, don't install it globally

de5e04a

This makes it possible to use Grunt without installing grunt-cli globally which makes the whole process more resilient.

mgol force-pushed the core-updates branch from 9fa2a54 to de5e04a Compare May 25, 2016 14:14

Build: Don't run tests on IE 8 with jQuery Core 2 and newer

441a597

scottgonzalez pushed a commit that referenced this pull request May 25, 2016

Build: Add jQuery 1.12/2.2 to the test configuration

468f1e3

Ref gh-1706

scottgonzalez pushed a commit that referenced this pull request May 25, 2016

Build: Add bower_components to .gitignore

6812ca4

Ref gh-1706

scottgonzalez pushed a commit that referenced this pull request May 25, 2016

Build: Add grunt-cli to devDependencies, don't install it globally

e6fd82d

This makes it possible to use Grunt without installing grunt-cli globally which makes the whole process more resilient. Ref gh-1706

scottgonzalez closed this in 827bf39 May 25, 2016

mgol deleted the core-updates branch May 25, 2016 20:44

mgol mentioned this pull request May 26, 2016

Tests: Stop testing against core 2.0.2 on testswarm #1707

Closed

Add jQuery 1.12/2.2 to the test configuration + minor updates #1706

Add jQuery 1.12/2.2 to the test configuration + minor updates #1706

Uh oh!

Conversation

mgol commented May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scottgonzalez commented May 25, 2016

Uh oh!

scottgonzalez commented May 25, 2016

Uh oh!

scottgonzalez May 25, 2016

Choose a reason for hiding this comment

Uh oh!

mgol May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scottgonzalez May 25, 2016

Choose a reason for hiding this comment

Uh oh!

mgol commented May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scottgonzalez commented May 25, 2016

Uh oh!

scottgonzalez commented May 25, 2016

Uh oh!

mgol commented May 25, 2016

Uh oh!

scottgonzalez May 25, 2016

Choose a reason for hiding this comment

Uh oh!

mgol May 25, 2016

Choose a reason for hiding this comment

Uh oh!

mgol commented May 25, 2016

Uh oh!

scottgonzalez commented May 25, 2016

Uh oh!

mgol commented May 25, 2016

Uh oh!

scottgonzalez commented May 25, 2016

Uh oh!

mgol commented May 25, 2016

Uh oh!

mgol commented May 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

mgol commented May 25, 2016 •

edited

Loading

mgol May 25, 2016 •

edited

Loading

mgol commented May 25, 2016 •

edited

Loading