Tests: Stop testing against core 2.0.2 on testswarm #1707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery 2.0.3 fixed very few things from 2.0.2, the list is here: http://blog.jquery.com/2013/07/03/jquery-1-10-2-and-2-0-3-released/ One of the fixes was http://bugs.jquery.com/ticket/13980, though which was about cross-domain iframe issues. The problem is TestSwarm loads a cross-domain iframe: the main page is swarm.jquery.org, the frame is on builds.jenkins.jquery.com so it might be causing issues. You can see jQuery UI tests are timing out in all IE versions in jQuery 2.0.2: http://swarm.jquery.org/job/2918 The problem is that it doesn't just fail, it starves the available IE pool, making it sometimes harder for other projects to get their tests run on IE. That's why tests with jQuery 2.0.2 on TestSwarm need to be removed as it's been done with 1.10.1. Refs #12745 Refs c2224bf Refs jquerygh-1706
|
By analyzing the blame information on this pull request, we identified @jzaefferer, @gnarf and @scottgonzalez to be potential reviewers |
|
An example problematic run: http://swarm.jquery.org/job/2918. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery 2.0.3 fixed very few things from 2.0.2, the list is here:
http://blog.jquery.com/2013/07/03/jquery-1-10-2-and-2-0-3-released/
One of the fixes was http://bugs.jquery.com/ticket/13980, though which was
about cross-domain iframe issues. The problem is TestSwarm loads a cross-domain
iframe: the main page is swarm.jquery.org, the frame is on
builds.jenkins.jquery.com so it might be causing issues. You can see jQuery UI
tests are timing out in all IE versions in jQuery 2.0.2:
http://swarm.jquery.org/job/2918
The problem is that it doesn't just fail, it starves the available IE pool,
making it sometimes harder for other projects to get their tests run on IE.
That's why tests with jQuery 2.0.2 on TestSwarm need to be removed as it's been
done with 1.10.1.
Refs #12745
Refs c2224bf
Refs gh-1706