Skip to content

Tests: Skip a scrollbar test in jQuery 3.2 #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Tests: Skip a scrollbar test in jQuery 3.2 #1927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/unit/position/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,13 @@ QUnit.test( "within", function( assert ) {
}, "flipfit - left top" );
} );

QUnit.test( "with scrollbars", function( assert ) {
// jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers.
// This is fixed in version 3.3, see https://github.com/jquery/jquery/issues/3589.
// As the data here comes from jQuery directly and the changes to fix it
// are non-trivial: https://github.com/jquery/jquery/pull/3656, just accept
// that scrollbar data in this jQuery version is inaccurate.
QUnit[ jQuery.fn.jquery.substring( 0, 4 ) === "3.2." ? "skip" : "test" ](
"with scrollbars", function( assert ) {
assert.expect( 4 );

$( "#scrollx" ).css( {
Expand Down