replaces jscs with eslint #1942
Conversation
|
Nice concise PR! |
eslint.json
Outdated
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "extends": "eslint:recommended", | |||
There was a problem hiding this comment.
UI should use the jQuery config, similarly as jQuery itself does.
There was a problem hiding this comment.
Im not sure we can get away from using the standardized eslint configuration file
|
Went ahead and removed jshint from the package. Let me know if there are any other changes you would like to see |
| src: [ "tests/**/*.js" ] | ||
| } | ||
| } | ||
| target:["demos/**/*.js", "build/**/*.js", "ui/**/*.js"] |
There was a problem hiding this comment.
This doesn't follow the jQuery code style with regards to spacing; doesn't ESLint verify it?
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "extends": "eslint:recommended", | |||
There was a problem hiding this comment.
jQuery projects are not supposed to use this preset but the jQuery one. This is to me a prerequisite to the migration, we can't migrate to a preset that doesn't verify rules jQuery cares about.
There was a problem hiding this comment.
which preset would you recommend then?
There was a problem hiding this comment.
The official jQuery one: https://www.npmjs.com/package/eslint-config-jquery
|
I did the ESLint work in #1958, so I'm closing this PR. |
Component: Core Dependency Library
The JSCS project has been archived and now contains security flaws. Migrated to ESLint to continue to provide linting service while alleviating the security concerns.
Fixes #15393