Skip to content

Build: Migrate from JSHint & JSCS to ESLint #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2021
Merged

Build: Migrate from JSHint & JSCS to ESLint #1958

merged 4 commits into from
Jun 6, 2021

Conversation

mgol
Copy link
Member

@mgol mgol commented Jun 2, 2021

The work is divided into three commits with (mostly, there are exceptions) the following work:

  1. The actual switch to ESLint + fixes done by ESLint autofix.
  2. Fixing the strict rule.
  3. Manually fixing remaining violations.
  4. Fixing a test issue caused by introducing strict mode.

Previously, while JSCS was only running in the build process in the command line, JSHint was also running in TestSwarm. There's no official ESLint version running in the browser so I opted to drop this feature; Core doesn't use it and I don't think it's important enough to hold off the switch to ESLint; you will get nice feedback when building in the terminal anyway. Please let me know if that's not acceptable for some reason.

@mgol mgol marked this pull request as ready for review June 2, 2021 20:41
@mgol mgol requested a review from fnagel June 2, 2021 20:42
@mgol mgol mentioned this pull request Jun 2, 2021
@fnagel
Copy link
Member

fnagel commented Jun 4, 2021

Previously, while JSCS was only running in the build process in the command line, JSHint was also running in TestSwarm. There's no official ESLint version running in the browser so I opted to drop this feature; Core doesn't use it and I don't think it's important enough to hold off the switch to ESLint

As long as the new ESLint runs with each build (and here in the GitHub / CI setup) I'm fine with the change.

Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

Looks good expect for one thing (the removed x variable). Amazing how many formatting issues have been fixed, even though there have been CGL tests in place...

@mgol mgol merged commit 70dae67 into jquery:main Jun 6, 2021
@mgol mgol deleted the eslint branch June 6, 2021 22:58
@mgol mgol added this to the 1.13.0 milestone Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants