Skip to content

Build: Migrate from JSHint & JSCS to ESLint #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgol merged 4 commits into from
Jun 6, 2021
Merged

Build: Migrate from JSHint & JSCS to ESLint #1958

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
434f1a2
Build: Migrate from JSHint to ESLint - apply autofix
mgol May 22, 2021
33c116d
Build: Enable the `strict` ESLint rule
mgol Jun 2, 2021
f885392
Build: Fix remaining ESLint violations
mgol Jun 2, 2021
27351b8
Build: Tests fix
mgol Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Build: Tests fix
  • Loading branch information
@mgol
mgol committed Jun 2, 2021
commit 27351b8e766438a79c259d4e81cbf7598ffdd2e8
12 changes: 9 additions & 3 deletions ui/widgets/resizable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,15 @@ $.widget( "ui.resizable", $.ui.mouse, {
// TODO: determine which cases actually cause this to happen
// if the element doesn't have the scroll set, see if it's possible to
// set the scroll
el[ scroll ] = 1;
has = ( el[ scroll ] > 0 );
el[ scroll ] = 0;
try {
el[ scroll ] = 1;
has = ( el[ scroll ] > 0 );
el[ scroll ] = 0;
} catch ( e ) {

// `el` might be a string, then setting `scroll` will throw
// an error in strict mode; ignore it.
}
return has;
},

Expand Down