Droppable: Make the undocumented refreshPositions option standard to recalculate positions. Fixed #5003 - Scroll on Droppable Demo Breaks Demo #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recalculate positions. Fixed #5003 - Scroll on Droppable Demo Breaks Demo
|
This does seem to solve the problem mentioned in the ticket. It doesn't seem like this would be a very bad perf hit either unless you have a whole lot of droppables... This could probably be pulled @scottgonzalez |
|
Unfortunately I think this will actually be a big problem for certain users. I'd be more comfortable changing the default behavior to always update, rather than forcing it to always update. We can't make that change in 1.8.x though and we shouldn't change options in 1.9 since the whole API is changing in 2.0. Perhaps we can listen for scroll events and refresh on scroll. |
|
I have changed the fix to listen for scroll in this pull #342. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Droppable: Make the undocumented refreshPositions option standard to recalculate positions. Fixed #5003 - Scroll on Droppable Demo Breaks Demo