Tabs isLocal function was not compatible with HTML5 push state #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isLocal function was not compatible with HTML5 push state as the url could have changed since the page was loaded as in cases with Backbone.js
|
Thanks. Please move rhash outside of isLocal since you're now regenerating the regex on every call. Also, please split the return statement into two lines again. |
|
Has anyone else seen this behavior? |
scottgonzalez
added a commit
that referenced
this pull request
Jan 19, 2012
Tabs isLocal function was not compatible with HTML5 push state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLocal function was not compatible with HTML5 push state as the url could have changed since the page was loaded as in cases with Backbone.js. The currentPage variable was generate on page load and did not listen for changes in the URL. So I have changed it so it live checks the anchor against the window location. We now have it working in backbone.js