Skip to content

Tabs isLocal function was not compatible with HTML5 push state #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2012
Merged

Tabs isLocal function was not compatible with HTML5 push state #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eef633e
Bug fix for isLocal function in jQuery Tabs.
arhea Jan 3, 2012
3c4e40d
Removed regex from function and split return into two lines.
arhea Jan 3, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions ui/jquery.ui.tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,20 @@
*/
(function( $, undefined ) {

var tabId = 0;
var tabId = 0,
rhash = /#.*$/;

function getNextTabId() {
return ++tabId;
}

var isLocal = (function() {
var rhash = /#.*$/,
currentPage = location.href.replace( rhash, "" );

return function( anchor ) {
// clone the node to work around IE 6 not normalizing the href property
// if it's manually set, i.e., a.href = "#foo" kills the normalization
anchor = anchor.cloneNode( false );
return anchor.hash.length > 1 &&
anchor.href.replace( rhash, "" ) === currentPage;
};
})();
var isLocal = function( anchor ) {
// clone the node to work around IE 6 not normalizing the href property
// if it's manually set, i.e., a.href = "#foo" kills the normalization
anchor = anchor.cloneNode( false );
return anchor.hash.length > 1 &&
anchor.href.replace( rhash, "" ) === location.href.replace( rhash, "" );
};

$.widget( "ui.tabs", {
version: "@VERSION",
Expand Down