Skip to content

Effects: set right/bottom to 'auto' so effects work with dir=rtl. Fixed #6736 - Bug in slide effect when dir=rtl and has position.right #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Effects: set right/bottom to 'auto' so effects work with dir=rtl. Fixed #6736 - Bug in slide effect when dir=rtl and has position.right #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c8e22b
Add saved-props: 'bottom' and 'right'
allpro Dec 13, 2010
35c7af3
Add saved-props: 'bottom' and 'right'
allpro Dec 13, 2010
45e417d
Add saved-props: 'bottom' and 'right'
allpro Dec 13, 2010
7717489
Add saved-props: 'bottom' and 'right'
allpro Dec 13, 2010
b47aa7b
Added element.css: right: 'auto', bottom: 'auto'
allpro Dec 13, 2010
8d525c5
Add saved-props: 'bottom' and 'right'
allpro Dec 13, 2010
b335a68
Add saved-props: 'bottom' and 'right'
allpro Dec 13, 2010
36fb0b2
Add saved-props (props & props1): 'bottom' and 'right'
allpro Dec 13, 2010
e5f8e31
Add saved-props: 'bottom' and 'right'
allpro Dec 13, 2010
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/jquery.effects.blind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $.effects.blind = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left'];
var el = $(this), props = ['position','top','bottom','left','right'];

// Set options
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.effects.bounce.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $.effects.bounce = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left'];
var el = $(this), props = ['position','top','bottom','left','right'];

// Set options
var mode = $.effects.setMode(el, o.options.mode || 'effect'); // Set Mode
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.effects.clip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $.effects.clip = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left','height','width'];
var el = $(this), props = ['position','top','bottom','left','right','height','width'];

// Set options
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.effects.core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ $.extend($.effects, {
props[pos] = 'auto';
}
});
element.css({position: 'relative', top: 0, left: 0 });
element.css({position: 'relative', top: 0, left: 0, right: 'auto', bottom: 'auto' });
}

return wrapper.css(props).show();
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.effects.drop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $.effects.drop = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left','opacity'];
var el = $(this), props = ['position','top','bottom','left','right','opacity'];

// Set options
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.effects.fold.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $.effects.fold = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left'];
var el = $(this), props = ['position','top','bottom','left','right'];

// Set options
var mode = $.effects.setMode(el, o.options.mode || 'hide'); // Set Mode
Expand Down
4 changes: 2 additions & 2 deletions ui/jquery.effects.scale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ $.effects.size = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left','width','height','overflow','opacity'];
var props1 = ['position','top','left','overflow','opacity']; // Always restore
var el = $(this), props = ['position','top','bottom','left','right','width','height','overflow','opacity'];
var props1 = ['position','top','bottom','left','right','overflow','opacity']; // Always restore
var props2 = ['width','height','overflow']; // Copy for children
var cProps = ['fontSize'];
var vProps = ['borderTopWidth', 'borderBottomWidth', 'paddingTop', 'paddingBottom'];
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.effects.shake.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $.effects.shake = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left'];
var el = $(this), props = ['position','top','bottom','left','right'];

// Set options
var mode = $.effects.setMode(el, o.options.mode || 'effect'); // Set Mode
Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.effects.slide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $.effects.slide = function(o) {
return this.queue(function() {

// Create element
var el = $(this), props = ['position','top','left'];
var el = $(this), props = ['position','top','bottom','left','right'];

// Set options
var mode = $.effects.setMode(el, o.options.mode || 'show'); // Set Mode
Expand Down