Effects: set right/bottom to 'auto' so effects work with dir=rtl. Fixed #6736 - Bug in slide effect when dir=rtl and has position.right #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects: set right/bottom to 'auto' so effects work with dir=rtl.
Fixed #6736 - Bug in slide effect when dir=rtl and has position.right
This bug affected 8 effects. Some were completely broken and some had only misalignment issues (jumping text at start or end).
The fixes were simple: Add 'right' and 'bottom' to the save props in each widget, and modify effects.core to set right:auto and bottom:auto at the same time it sets left:0 and top:0.
Demo illustrating the issues: http://layout.jquery-dev.net/test/slide_rtl.html
Demo with patched effects: http://layout.jquery-dev.net/test/slide_rtl_patched.html