Draggable: Fixed snapping of bigger objects to smaller objects. #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… #8165 - Problem with snap option when dragging big rect.
|
Hi @mattyway, thanks again for contributing this patch. We recently re-enabled the test suite for draggable. In order for us to land this patch, we'd need a few tests added to the test suite proving this doesn't break existing functionality and also that it fixes the bug as described. Can you add some tests here please? |
|
Thanks @mikesherov. I will add some tests. |
|
@mattyway, ping! Thanks again for contributing. I'm eager to land a pull here but really need this to be rebased and unit tested. |
|
@mattyway, thanks again for contributing the patch. Unfortunately, we're going to close it due to inactivity as it's been a few months and still needs unit tests. Feel free to submit a new patch with tests if you'd like. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #8165 - Problem with snap option when dragging big rect.