Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly by zbigniewmotyka · Pull Request #796 · jquery/jquery-ui

zbigniewmotyka · 2012-10-29T09:02:32Z

Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly

scottgonzalez · 2012-10-29T20:04:12Z

Is this a duplicate of #780?

scottgonzalez · 2012-10-29T20:04:53Z

The code here is certainly a lot smaller. What's the technical difference?

zbigniewmotyka · 2012-10-30T09:22:09Z

In #780 condition checks if at least one of corners or edges is in area which should cause snapping.
In my commit condition checks if there is at least one condition which shouldn't cause snapping (top edge of rectangle 1 is too far from bottom edge of rectangle 2, or bottom edge of rectangle 1 is too far from top edge of rectangle 2, or left edge of rectangle 1 is too far from right edge of rectangle 2, or right edge of rectangle 1 is too far from left edge of rectangle 2).

mikesherov · 2012-11-05T19:53:46Z

Hi @zmszaman, thanks again for contributing this patch. We recently re-enabled the test suite for draggable. In order for us to land this patch, we'd need a few tests added to the test suite proving this doesn't break existing functionality and also that it fixes the bug as described. Can you add some tests here please?

zbigniewmotyka · 2012-11-06T08:59:18Z

I ran tests and it doesn't break existing functionality. Every tests passes.
I will write test for this bug as soon as I find some free time.

mikesherov · 2012-11-17T04:03:49Z

@zmszaman, thanks again for contributing the patch! I'm eager to land a fix. Just to recap what we need to land this pull request:

unit tests showing this fixing the bug.
remove the "yes, I know this is insane ;)" comment and add a better one explaining what you explained to @scottgonzalez here: Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly #796 (comment)
sign the CLA: http://jquery.github.com/cla.html

Please let me know when you've completed that! Thanks again.

mikesherov · 2013-01-26T14:12:05Z

@zmszaman, I can write the tests if you can't find the time, but please sign http://jquery.github.com/cla.html so I can land this patch.

zbigniewmotyka · 2013-03-12T15:03:04Z

I just sign CLA. I will be grateful if you write the test.

mikesherov · 2013-03-12T18:54:29Z

@zmszaman, can you rebase this code, it's not going to merge cleanly at this point.

…. Fixes #6830 - Allow Icons to be specified for Dialog buttons.

… overhaul unit test for destroy method.

…ontent, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open

…able methods. Disabling dialogs is not supported.

… check. Fixes #8824 - Deprecate array notation for position option.

…naddressable TODOs.

…r instead of appending to body.

… to pass.

…ition option.

… to create the button.

…es not close for first click on chrome.

…8838 - Dialog: Close icon does not work in dialog larger than the window in IE.

…o prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability.

…ixed #7960 - Dialog: Modal dialogs do not disable resizables on the page.

…ca5fbf

…4485: Portlet demo is buggy.

…er from an image. Fixes #5129 - Sortable: Unable to use an image as a placeholder in Firefox.

…nt incorrectly calculates padding and border

…nal functions when proxying, don't rename originals.

… floating. Fixes #8792: Issue with floated items in connected lists.

…. Fixes #9041: the over event fires on every pixel movement

…es #9150 - CSS Framework: Add ui-icon-blank. This essentially reverts 1fe06f0 and the fix for #5659.

… disabled option. Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled Fixes #6039 - Droppable : disabled should not have ui-state-disabled

…unt-css and grunt-html, update custom tasks. Drop qunit-junit plugin, not worth the trouble. Update release script to run grunt-prepare after npm-install.

…ds a new version of grunt-compare-size to actuall work

zbigniewmotyka · 2013-03-13T09:06:00Z

I did rebase on the code

mikesherov · 2013-03-16T01:26:33Z

@zmszaman, please try again. First pull latest upstream master, then rebase your branch against latest master. Looks like you rebased against an old master.

mikesherov · 2013-03-16T14:50:10Z

OK, I'll go ahead and rebase this for you when I land it.

mikesherov · 2013-03-16T15:55:47Z

Thanks for contributing! Patch landed in bd126a9

For future reference, if you'd like to contribute more patches:

Make sure your git name and email match the records you entered into our CLA.
Make sure you submit a unit test supporting your change.
Make sure you don't develop in the master branch.... as you can see, it's hard to rebase from master.

Thanks again!

mikesherov mentioned this pull request Nov 9, 2012

Draggable: Fixed snapping of bigger objects to smaller objects. #780

Closed

jzaefferer and others added 20 commits March 13, 2013 09:50

Dialog: Tiny code improvements

b53ef81

Dialog: Pass through icons and showText (as 'text') options to button…

c44bd59

…. Fixes #6830 - Allow Icons to be specified for Dialog buttons.

Dialog: Extend visual test to verify DOM position restore on destroy;…

d6fa515

… overhaul unit test for destroy method.

Dialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace

1f6f167

Dialog: Extend autofocus, starting with [autofocus], then :tabbable c…

9d18aee

…ontent, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open

Dialog: Removed broken disabled option from dialog, defuse disable/en…

44529c9

…able methods. Disabling dialogs is not supported.

Dialog: Move array notation support for position option to backCompat…

5d251b4

… check. Fixes #8824 - Deprecate array notation for position option.

Dialog: Refactor overlay handling into two instance methods. Remove u…

e5ecebf

…naddressable TODOs.

Dialog: Improve _destroy method, detaching dialog content from wrappe…

d573ebf

…r instead of appending to body.

Dialog: Add missing unit test for aria-describedby attribute

bc3b27e

Dialog: Exclude deprecated units from phantomjs

a9079b7

Dialog: Update focus-tabbable test with a timer workaround to get IE8…

d475379

… to pass.

Dialog: Follow-up to 9fe3a62 - also deprecate string notation for pos…

74121c0

…ition option.

Dialog: Follow-up to c77ca67 - exclude button options from properties…

dcff6e3

… to create the button.

Dialog: Update position when size is changed. Fixes #8789 - Dialog do…

a13b752

…es not close for first click on chrome.

Dialog: Don't focus dialog when mousedown is on close button. Fixes #…

96dcffd

…8838 - Dialog: Close icon does not work in dialog larger than the window in IE.

Dialog: Extract setting the title into a _title method, use .text() t…

58edc20

…o prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability.

Dialog: Add unit test to cover #8789 and #8838.

45e1955

Resizable: Modified the default z-index value of resizable handles. F…

733d36e

…ixed #7960 - Dialog: Modal dialogs do not disable resizables on the page.

Fix AUTHORS.txt, remove the various duplicate entries - follow-up to 2…

8f380f7

…ca5fbf

tjvantoll and others added 25 commits March 13, 2013 09:51

Sortable: Adding a min-width to the body on the portlet demo. Fixed #…

7ef3925

…4485: Portlet demo is buggy.

Slider tests: Don't use .on().

e519f84

Slider tests: Use ui-slider not uiSlider for data key.

5c5a3cc

Draggable Tests: Add test coverage for supported options

5a3d8f4

Draggable Tests: Style Sweep

d3abe08

Draggable Tests: Fix snap test failures in IE8

d8d7484

Draggable Tests: Fix containment tests

46738a0

Sortable: Copy the src of the original item when creating a placehold…

fbe0720

…er from an image. Fixes #5129 - Sortable: Unable to use an image as a placeholder in Firefox.

Sortable tests: Added alt attributes to images.

71342ff

Draggable: Fix border containment. Fixed #5569 - Draggable: Containme…

9c225ad

…nt incorrectly calculates padding and border

Draggable: Account for descendants in handle.

9e35b18

Removed guard against duplicate loading. Use safe references to origi…

dec89db

…nal functions when proxying, don't rename originals.

Sortable: Skip items that are not at the same line as the cursor when…

9ddeec0

… floating. Fixes #8792: Issue with floated items in connected lists.

Sortable: Skip triggering over event if it's alreay over the continer…

6d89ee7

…. Fixes #9041: the over event fires on every pixel movement

Sortable Tests: Add tests to support #9041 and #8792

67e420d

Draggable tests: Don't use .on().

75cb47a

CSS Framework: Add ui-icon-blank class for an icon with no image. Fix…

edf0377

…es #9150 - CSS Framework: Add ui-icon-blank. This essentially reverts 1fe06f0 and the fix for #5659.

Build: Migrate to grunt 0.4. Rename to Gruntfile, upgrade to newer gr…

81da37e

…unt-css and grunt-html, update custom tasks. Drop qunit-junit plugin, not worth the trouble. Update release script to run grunt-prepare after npm-install.

Build: Switch from grunt-css to the equivalent grunt-contrib tasks

cc0ecac

Build: Don't call DB's grunt-prepare task, not needed anymore

ca44da2

Build: Update to grunt-contrib-qunit 0.2.0 to get latest PhantomJS

b34ba84

Build: Fix the key for the 'all' subtask for compare_size. Stills nee…

b68ca0c

…ds a new version of grunt-compare-size to actuall work

Upgrade to grunt-git-authors 1.2.0.

ea81b27

Updated AUTHORS.txt.

f9c8755

mikesherov closed this Mar 16, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly#796

Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly#796
zbigniewmotyka wants to merge 346 commits into
jquery:masterfrom
zbigniewmotyka:master

zbigniewmotyka commented Oct 29, 2012

Uh oh!

scottgonzalez commented Oct 29, 2012

Uh oh!

scottgonzalez commented Oct 29, 2012

Uh oh!

zbigniewmotyka commented Oct 30, 2012

Uh oh!

mikesherov commented Nov 5, 2012

Uh oh!

zbigniewmotyka commented Nov 6, 2012

Uh oh!

mikesherov commented Nov 17, 2012

Uh oh!

mikesherov commented Jan 26, 2013

Uh oh!

zbigniewmotyka commented Mar 12, 2013

Uh oh!

mikesherov commented Mar 12, 2013

Uh oh!

zbigniewmotyka commented Mar 13, 2013

Uh oh!

mikesherov commented Mar 16, 2013

Uh oh!

mikesherov commented Mar 16, 2013

Uh oh!

mikesherov commented Mar 16, 2013

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants

Conversation

zbigniewmotyka commented Oct 29, 2012

Uh oh!

scottgonzalez commented Oct 29, 2012

Uh oh!

scottgonzalez commented Oct 29, 2012

Uh oh!

zbigniewmotyka commented Oct 30, 2012

Uh oh!

mikesherov commented Nov 5, 2012

Uh oh!

zbigniewmotyka commented Nov 6, 2012

Uh oh!

mikesherov commented Nov 17, 2012

Uh oh!

mikesherov commented Jan 26, 2013

Uh oh!

zbigniewmotyka commented Mar 12, 2013

Uh oh!

mikesherov commented Mar 12, 2013

Uh oh!

zbigniewmotyka commented Mar 13, 2013

Uh oh!

mikesherov commented Mar 16, 2013

Uh oh!

mikesherov commented Mar 16, 2013

Uh oh!

mikesherov commented Mar 16, 2013

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants