Skip to content

Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 346 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
346 commits
Select commit Hold shift + click to select a range
b53ef81
Dialog: Tiny code improvements
jzaefferer Nov 16, 2012
c44bd59
Dialog: Pass through icons and showText (as 'text') options to button…
jzaefferer Nov 16, 2012
d6fa515
Dialog: Extend visual test to verify DOM position restore on destroy;…
jzaefferer Nov 16, 2012
1f6f167
Dialog: Cleanup in ticket tests: TODO to merge one test, fix whitespace
jzaefferer Nov 16, 2012
9d18aee
Dialog: Extend autofocus, starting with [autofocus], then :tabbable c…
jzaefferer Nov 16, 2012
44529c9
Dialog: Removed broken disabled option from dialog, defuse disable/en…
jzaefferer Nov 17, 2012
5d251b4
Dialog: Move array notation support for position option to backCompat…
jzaefferer Nov 17, 2012
e5ecebf
Dialog: Refactor overlay handling into two instance methods. Remove u…
jzaefferer Nov 17, 2012
d573ebf
Dialog: Improve _destroy method, detaching dialog content from wrappe…
jzaefferer Nov 17, 2012
bc3b27e
Dialog: Add missing unit test for aria-describedby attribute
jzaefferer Nov 17, 2012
a9079b7
Dialog: Exclude deprecated units from phantomjs
jzaefferer Nov 17, 2012
d475379
Dialog: Update focus-tabbable test with a timer workaround to get IE8…
jzaefferer Nov 17, 2012
74121c0
Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for p…
jzaefferer Nov 21, 2012
dcff6e3
Dialog: Follow-up to c77ca67 - exclude button options from properties…
jzaefferer Nov 22, 2012
a13b752
Dialog: Update position when size is changed. Fixes #8789 - Dialog do…
kborchers Nov 25, 2012
96dcffd
Dialog: Don't focus dialog when mousedown is on close button. Fixes #…
jzaefferer Nov 26, 2012
58edc20
Dialog: Extract setting the title into a _title method, use .text() t…
jzaefferer Nov 26, 2012
45e1955
Dialog: Add unit test to cover #8789 and #8838.
kborchers Nov 25, 2012
733d36e
Resizable: Modified the default z-index value of resizable handles. …
tjvantoll Nov 24, 2012
8f380f7
Fix AUTHORS.txt, remove the various duplicate entries - follow-up to …
jzaefferer Nov 26, 2012
e67aa0e
Autocomplete demo: Combobox cleanup.
scottgonzalez Nov 26, 2012
25e4b56
Dialog: Moved resizable handle test from resizable.
scottgonzalez Nov 26, 2012
b88e0b3
Tabs: Calculate border and padding on tabs container. Fixed #8836: He…
petersendidit Nov 26, 2012
41bd53c
Fixed order of authors.
scottgonzalez Nov 26, 2012
eaeb3e5
Button: Let change handler handle display and aria update. Fixed #551…
Nov 27, 2012
3ce4723
Button Tests: move aria-pressed test to correct module
mikesherov Nov 27, 2012
12aae08
Datepicker: Remove support for setting options via custom attributes.
scottgonzalez Nov 27, 2012
320b13e
Datepicker: Remove JSHint overrides.
scottgonzalez Nov 27, 2012
9824bc4
Effects: Use $ instead of jQuery in $.effects.animateClass. Fixes #88…
urandom Nov 26, 2012
4cb21f9
Theme: removed obsolete vendor-specific prefixes. Fixed #8834 - Theme…
selfthinker Nov 27, 2012
51c6d58
Autocomplete demo: Combobox: Encode search term inside tooltips. Fixe…
scottgonzalez Nov 27, 2012
b03abf4
Tooltip: Escape the title attribute so that it's treated as text and …
scottgonzalez Nov 27, 2012
b965918
Button: Strange space between buttons in IE 7. Fixed #5253 - Toolbar …
Nov 27, 2012
e2da502
Autocomplete: When appendTo is a jQuery object or a DOM element, don'…
scottgonzalez Nov 28, 2012
6dac9e5
Button tests: simulated clicks aren't perfect in oldIE and Opera
mikesherov Nov 28, 2012
af15fea
Button tests: Work around a quirk in Opera.
scottgonzalez Nov 29, 2012
4640157
Progressbar demos: Removed animated demo.
scottgonzalez Nov 29, 2012
286a468
Progressbar demos: Removed resize demo.
scottgonzalez Nov 29, 2012
d6902e7
Dialog: Use consistent code for appending to body
jzaefferer Nov 29, 2012
a504a88
Progressbar demos: Cleanup.
scottgonzalez Nov 29, 2012
cd172e1
Button: fixed inconsistent button styling in most browsers. Fixes #79…
selfthinker Nov 29, 2012
7af7603
Theme: removed or changed occurrences of zoom. Fixes #7975 - Remove i…
selfthinker Nov 29, 2012
504860b
Progressbar: Create and destroy indeterminate overlay as needed and c…
kborchers Nov 30, 2012
9700d36
Progressbar: Add custom label demo.
kborchers Nov 30, 2012
a8c0a71
Dialog: Ensure all animations finish and clean up themselve when dest…
jzaefferer Nov 30, 2012
603a5da
Grunt: Set testswarm/browserSets from JSON file.
Krinkle Nov 17, 2012
64c569c
Resizable: Respect containment for alsoResize option. Fixes #4603 - R…
scottgonzalez Dec 3, 2012
fac854a
Dialog: Restrict title to a single line. Fixes #7773 - Dialog: If tit…
jzaefferer Dec 2, 2012
ae3f3c4
Dialog: Adjust southeast resize handle to not be visible and more clo…
scottgonzalez Dec 3, 2012
70c33e9
Widget tests: Fixed order of actual and expected.
scottgonzalez Dec 3, 2012
a983041
Widget: Don't modify the prototype passed to $.widget(). Fixes #8876 …
scottgonzalez Dec 3, 2012
3dfa90c
Dialog: Cleanup style properties on _destroy. Reenables style check i…
jzaefferer Dec 3, 2012
bce2f20
Menu: Remove display property on hidden submenus instead of setting d…
jzaefferer Dec 3, 2012
e71fbb7
Tabs: Remove display property on hidden panels instead of setting dis…
jzaefferer Dec 3, 2012
79272c6
Dialog: Remove the instance-storing for the overlay, just create one …
jzaefferer Dec 4, 2012
fb2109b
Dialog: Refactor _createOverlay and _destroyOverlay to use widget met…
jzaefferer Dec 4, 2012
26173a9
Progressbar: Custom label demo cleanup
kborchers Dec 4, 2012
0e5f5c1
Revert "Tabs: Remove display property on hidden panels instead of set…
scottgonzalez Dec 4, 2012
d1b126c
Revert "Menu: Remove display property on hidden submenus instead of s…
scottgonzalez Dec 4, 2012
73955a0
Revert "Dialog: Cleanup style properties on _destroy. Reenables style…
scottgonzalez Dec 4, 2012
ebfd44b
Dialog: Remove unnecessary margin on title.
scottgonzalez Dec 4, 2012
617a31e
Dialog: Remove width, min-height, height styles on destroy. Fixes #81…
scottgonzalez Dec 4, 2012
a59283c
Datepicker: Handle changes to the disabled option. Fixes #8883 - Date…
scottgonzalez Dec 5, 2012
687d728
Datepicker: Added Belarusian locale. Fixes #8885 - Datepicker: Add Be…
wizardist Dec 2, 2012
3b972a6
Datepicker: Added Norwegian Bokmål and Norwegian Nynorsk locales. Fix…
Dec 3, 2012
ab7c9d3
Dialog: Restore inline styles for dimensions/display. Fixes #8119 - D…
scottgonzalez Dec 5, 2012
1c822e8
Tabs: Decode URIs before comparing. Fixes #8877 - Tabs: isLocal funct…
scottgonzalez Dec 5, 2012
05a8bbb
Progressbar: Define defaults for callbacks.
scottgonzalez Dec 6, 2012
96d55e1
Progressbar: Only remove aria-valuenow for indeterminate progressbars…
scottgonzalez Dec 6, 2012
d5e464a
Progress tests: Cleanup.
scottgonzalez Dec 6, 2012
85b509d
Progressbar: Cleanup, byte shaving.
scottgonzalez Dec 6, 2012
5114f94
Datepicker: Run JSHint test in unit tests.
scottgonzalez Dec 6, 2012
36c8b5e
Progressbar: Take min into account when calculating percentage.
kborchers Dec 6, 2012
f8ebc3f
Progressbar: Add link to custom label demo in demo index.
kborchers Dec 6, 2012
cc5a654
Tabs: Reduce cyclomatic complexity.
scottgonzalez Dec 6, 2012
90fa784
Allow higher cyclomatic complexity in functions that sanely use switc…
scottgonzalez Dec 6, 2012
9baaaa0
Core: Removed $.ui.isOver() and $.ui.isOverAxis(). Fixes #8891 - Remo…
scottgonzalez Dec 6, 2012
1127494
Droppable: Added missing semicolon.
scottgonzalez Dec 6, 2012
25707e4
Position: Split out dimension parsing.
scottgonzalez Dec 6, 2012
ce8d42c
Build: Update grunt-junit, gets rid of the bogus xml files.
jzaefferer Dec 7, 2012
3d7107f
Build: Update to node-testswarm 0.3
jzaefferer Dec 7, 2012
90cf41c
Autocomplete: Handle detached elements for appendTo after create.
scottgonzalez Dec 7, 2012
8c9b872
Dialog: Added appendTo option. Fixes #7948 - Dialog: Allow dialog to …
scottgonzalez Dec 7, 2012
0515d79
Dialog: Respect maxHeight when determining size on open. Fixes #4820 …
scottgonzalez Dec 7, 2012
b7d4b06
Dev: Remove *_tickets.js test files and move the associated tests to …
mikesherov Dec 8, 2012
0e6e386
Dev: Change incorrect references in test suite from #main to #qunit-f…
mikesherov Dec 8, 2012
5b6d909
Dev: remove unnecessary simulated drag delegation in test suite
mikesherov Dec 9, 2012
f0d9001
Dialog tests: Updated markup for deprecated tests to match standard t…
scottgonzalez Dec 10, 2012
9a1a504
Core tests: Handle async focus in IE.
scottgonzalez Dec 10, 2012
de0abbc
Button tests: Handle async focus in IE.
scottgonzalez Dec 10, 2012
5eb5b96
Spinner tests: Better handling of async focus in IE.
scottgonzalez Dec 10, 2012
9dea43f
Dialog tests: More async focus handling to deal with IE8.
scottgonzalez Dec 10, 2012
3c64091
Spinner tests: Delay all the things to make IE happy. Maybe...
scottgonzalez Dec 10, 2012
5637408
Menu tests: Better handling of async focus in IE.
scottgonzalez Dec 11, 2012
a67e48a
Datepicker tests: Handle async focus in IE.
scottgonzalez Dec 11, 2012
890fb06
Dialog: Cleanup.
scottgonzalez Dec 11, 2012
c0d827b
Dev: remove todos from datepicker and dialog testsuite
mikesherov Dec 12, 2012
f2e931f
Dev: update jquery.simulate.js to latest version from http://github.c…
mikesherov Dec 12, 2012
20260dc
Dialog: Spacing.
scottgonzalez Dec 12, 2012
673d66c
Core: Removed $.ui.contains. Fixes #8902 - Remove $.ui.contains.
scottgonzalez Dec 12, 2012
ba51568
Progressbar: Moved .ui-progressbar-indeterminate to main element. Add…
scottgonzalez Dec 12, 2012
1285506
Core: Moved selectstart support test to deprecated section.
scottgonzalez Dec 12, 2012
5679e61
Added CONTRIBUTING.md.
scottgonzalez Dec 12, 2012
d46f4fd
Updated AUTHORS.txt.
scottgonzalez Dec 13, 2012
d8d901b
Release: Add support for pre-releases.
scottgonzalez Dec 13, 2012
3474496
Autocomplete: Combobox demo - Collapse menu when clicking button.
scottgonzalez Dec 13, 2012
0f36cd8
Dialog: Removed unnecessary style properties.
scottgonzalez Dec 14, 2012
4e9009c
Autocomplete: Append to closest .ui-front if available.
scottgonzalez Dec 14, 2012
0c1fd6a
All: Use .addBack() instead of .andSelf().
scottgonzalez Dec 14, 2012
7b199b8
Datepicker: Added Candian French locale. Fixes #8917 - Datepicker: Ad…
Thieum Dec 17, 2012
42efadf
Tooltip: Clear the tracking interval on close. Fixes #8920 -Tooltip p…
scottgonzalez Dec 18, 2012
78c36e3
Slider: Create clone of options.values during _create(). Fixed #8892 …
dominicbarnes Dec 6, 2012
9f5eb3a
Build: Added notStrictEqual to the globals list for unit tests.
scottgonzalez Dec 20, 2012
6b70635
Datepicker: Remove data event handlers from the dark ages.
scottgonzalez Dec 20, 2012
8b9325e
Dev: stop loading *_tickets.js in the test suite.
mikesherov Dec 22, 2012
5229615
Dialog Tests: Fix test fails due to window measurements in FF and IE7
mikesherov Dec 22, 2012
80f6c36
Draggable Tests: use jquery.simulate.js to simulate drag events
mikesherov Dec 22, 2012
1d0fd9f
Draggable Tests: add back in unreliable offset hack for cursorAt tests
mikesherov Dec 22, 2012
b2626c6
Datepicker: Use tabs for indentation.
mikesherov Dec 25, 2012
6580d2e
All: Convert single quotes to double quotes.
mikesherov Dec 25, 2012
20077aa
Tests: Convert single quotes to double quotes.
mikesherov Dec 26, 2012
bf28dd7
Spinner: Update button icons when option changes. Fixes #8926 - Spinn…
jzaefferer Dec 27, 2012
09211fa
Draggable Tests: Fix IE7 offset failures
mikesherov Dec 27, 2012
679abef
Spinner: Trigger start/spin/stop events when calling step/page method…
jzaefferer Dec 27, 2012
6d86a1c
Menu: Allow changing icons option after creation. Fixes #8927 - Menu:…
jzaefferer Dec 27, 2012
7d795c8
Create mouseHandled flag per instance instead of globally. Fixes #886…
kborchers Dec 28, 2012
f5ea4ba
Accordion: Fix testsuite overflow issue in IE7.
jzaefferer Dec 28, 2012
48f511b
Theme: Split opacityOverlay from opacityFilterOverlay on theme styles.
rxaviers Dec 28, 2012
524ffc7
Tabs: Update manipulation demo - use delegate instead of live (can't …
jzaefferer Dec 28, 2012
3584157
Tabs: Update manipulation demo - implement alt+del shortcut to remove…
jzaefferer Dec 28, 2012
f87fc6c
Add comment explaining the mouseHandled flag
kborchers Dec 30, 2012
6939b6f
Selectable tests: Removed a non-existent script tag causing a 404 in …
tjvantoll Dec 30, 2012
8a59187
Selectable: Account for scrolling on the helper's initial position. F…
tjvantoll Dec 29, 2012
c90f375
Draggable Tests: Cover all cursorAt option formats.
mikesherov Jan 2, 2013
58964fe
Slider: add options for event callbacks
mikesherov Jan 2, 2013
9440deb
Datepicker Tests: Prepare for widget-ization tests.
mikesherov Jan 2, 2013
77d2fcb
Tests: Correct all 404 errors in the test suite
mikesherov Jan 2, 2013
d299e43
Interactions: Update widget defaults to match documented API.
mikesherov Jan 2, 2013
8cc6235
Effects: Avoid cssHook blending in non-rgba browsers when the value i…
mikesherov Jan 3, 2013
addd54f
Dev: add .gitattributes file to force all line endings to LF
mikesherov Jan 3, 2013
23484c0
Core: Resume focus test based on the event, not the callback.
scottgonzalez Jan 8, 2013
480aec8
Datepicker i18n: Fix line endings.
scottgonzalez Jan 8, 2013
5049ffc
Update .gitattributes to only touch files with text content.
jzaefferer Jan 8, 2013
ab9b408
Libs/externals: Fix line endings.
jzaefferer Jan 8, 2013
b1686d2
Updated AUTHORS.txt.
scottgonzalez Jan 9, 2013
2a7cef2
Updated maintainers list.
scottgonzalez Jan 9, 2013
4e2a534
Release: Remove support for node <0.8.
scottgonzalez Jan 9, 2013
5324f1e
Release: Remove TODO for uploading release zip to GitHub since downlo…
scottgonzalez Jan 9, 2013
73b802b
Effects: fix backwards compatibility in animateClass for jQuery Core …
mikesherov Jan 9, 2013
58fc441
Update copyright year to 2013.
scottgonzalez Jan 10, 2013
c6fb619
Tooltip: Avoid errors on mouseover of tooltips with parents that have…
mikesherov Jan 11, 2013
6db0be7
Slider: Moved events to named functions (to allow extended plugins to…
dominicbarnes Jan 8, 2013
248c400
Build: Fix generate_themes task to adopt to changes in download builder.
jzaefferer Jan 14, 2013
a5bf44c
Updating the master version to 1.10.1pre.
jzaefferer Jan 14, 2013
4ab216e
Revert "Updating the master version to 1.10.1pre."
jzaefferer Jan 14, 2013
ae94bfa
Spinner: Inherit font color since we inherit background color. Fixes …
scottgonzalez Jan 15, 2013
430d80f
Updating to jQuery Color 2.1.2
gnarf Jan 16, 2013
401a184
Whitespace.
scottgonzalez Jan 16, 2013
144b958
Build: Check patch instead of minor to detect major releases.
scottgonzalez Jan 16, 2013
b25acf7
Updating to jQuery 1.9.0
kborchers Jan 17, 2013
9f501ca
Updating the master version to 1.10.1pre.
scottgonzalez Jan 17, 2013
536d749
Accordion: Properly set corner classes on refresh. Fixes #8995 - Acco…
scottgonzalez Jan 22, 2013
6dc98d1
Accordion: Add panel in addition to content for create event. Fixes #…
scottgonzalez Jan 22, 2013
6629642
Datepicker: Handle when yearRange is a year or a modifier. Fixed #899…
petersendidit Jan 23, 2013
db5840a
Dialog: Don't handle overlays on destory if there are not any. Fixed:…
petersendidit Jan 24, 2013
96f3584
Autocomplete demo: Fixed reference to widget instance.
scottgonzalez Jan 24, 2013
f33ae21
Dialog: Allow interaction with datepickers from modal dialogs. Fixes …
scottgonzalez Jan 25, 2013
c84dda3
Dialog: modified _createOverlay to _appendTo instead of document.body…
djQuery Jan 26, 2013
6bf059c
Slider: Added rounded corners to range area. Fixed #9024 - Slider: Ra…
backflip Jan 28, 2013
53171f5
Effects Core: make removeClass work correctly with changes jQuery 1.9…
petersendidit Jan 26, 2013
4806fa8
Autocomplete: Fix .data() references in demos. Fixes #9029 - Autocomp…
scottgonzalez Jan 30, 2013
6d37d9f
Dialog: Move call to _focusTabbable and triggering of open and focus …
kborchers Jan 30, 2013
c7e5892
Dialog Tests: Add test to ensure dialog keeps focus when clicking a m…
kborchers Jan 31, 2013
d3d9618
Dialog Tests: Cleanup el -> element
kborchers Jan 31, 2013
ff9f9de
Menu: Escape em and en dashes in regex. Fixes #9016 - Menu: Non-ASCII…
scottgonzalez Jan 31, 2013
37b9ea6
Sortable demo: Fix use of tabs API.
scottgonzalez Jan 31, 2013
a3a91af
Upgrade QUnit to 1.11.0. Fixes #8969 - Global test failure in Opera 1…
scottgonzalez Jan 31, 2013
bccc1e5
Datepicker demo: Simplify localization demo so that jqueryui.com work…
scottgonzalez Jan 31, 2013
f6aa03c
Dialog: Set the _isOpen flag immediately in open(). Fixes #8958 - Dia…
scottgonzalez Jan 31, 2013
cff3693
Dialog: Check for empty array in addition to empty object when checki…
scottgonzalez Feb 1, 2013
b7f18f1
Upgrade to node-testswarm 1.0. -alpha works well, tested with QUnit a…
jzaefferer Feb 1, 2013
525bd06
Dialog: Add effect files to deprecated testsuite to sync with non-dep…
jzaefferer Feb 1, 2013
aec1e02
Datepicker: Escape single quotes in tooltips. Fixes #9049 - Datepicke…
scottgonzalez Feb 1, 2013
7e35073
Draggable: Change $.ui.contains() to $.contains(). Fixes #9051 - Drag…
vahid-sohrabloo Feb 1, 2013
84247c6
oops...
scottgonzalez Feb 3, 2013
a7632b2
Dialog: Don't use ._on() for modal event handlers. Fixes #9048 - Dial…
scottgonzalez Feb 3, 2013
59c5ab7
Dailog: Cover iframes during drag and resize. Fixes #7650 - Dialog ca…
scottgonzalez Feb 3, 2013
aa7d34d
Fix file permissions in themes/base/images.
TravisCarden Jan 18, 2013
56c9e4f
Slider: Add disabled tests and remove disabled prop from handles
petersendidit Feb 1, 2013
1b4a7dc
Updating 'jQuery' to 1.9.1.
Feb 5, 2013
7161d45
Slider: allow range option to be changed. Fixed #5602 - Slider Does N…
petersendidit Jan 30, 2013
323f259
Autocomplete: Optimize element type checks for speed and size.
scottgonzalez Feb 5, 2013
f029753
Datepicker: Use entity number instead of entity name when escaping si…
scottgonzalez Feb 5, 2013
256b1e7
Autocomplete: Use .ui-front instead of .zIndex() for the suggestions …
scottgonzalez Feb 5, 2013
86c679c
Added .mailmap for top contributors.
scottgonzalez Feb 6, 2013
dabbf88
Slider: Coding standards for tests
petersendidit Feb 7, 2013
991d163
Draggable: Account for z-index set in CSS for the stack option. Fixe…
tjvantoll Feb 12, 2013
98b2818
Position: Handle decimal percentage offsets. Fixes #9076: percentage …
petersendidit Feb 12, 2013
47707e8
Datepicker i18n: Change Slovak day/month names to lowercase. Fixes #9…
scottgonzalez Feb 12, 2013
53957a5
Removing unnecessary wrapping of this in draggable's stack option han…
tjvantoll Feb 13, 2013
9361174
Theme: Collapse border in .ui-helper-cleafix. Fixes #8442 - CSS: ui-h…
scottgonzalez Feb 13, 2013
2d5d4ac
Updated AUTHORS.txt.
scottgonzalez Feb 13, 2013
5a8a883
Grunt: update generate_themes task to use the new DownloadBuilder API
rxaviers Feb 13, 2013
e4f5662
Build: Cleanup.
scottgonzalez Feb 15, 2013
a2e18a2
Build: Use fs.existsSync() instead of path.existsSync().
scottgonzalez Feb 15, 2013
a3de0a8
Updating the master version to 1.10.2pre.
scottgonzalez Feb 15, 2013
bed71c6
Sortable: Inject a CSS rule to style the cursor. Fixed #7389 - sortab…
ngsilverman Feb 13, 2013
2d0d88c
Dialog: Don't hard-code widget data key. Fixes #9097 - UI dialog inhe…
scottgonzalez Feb 18, 2013
a772ceb
Datepicker: Updated German locale. Fixes #9098 - Datepicker German lo…
wenz Feb 19, 2013
abd1ae2
Dialog: Extract check for which elements can gain focus into its own …
scottgonzalez Feb 20, 2013
00ea8ae
Sortable: When sorting table rows, create a td to force dimensions. F…
scottgonzalez Feb 21, 2013
8614eb6
Draggable: Revert flag honours Sortable revert speed. Fixed #9103 Dra…
steveu Feb 19, 2013
5499590
Tabs: Use border-bottom-width instead of border-bottom to remove the …
scottgonzalez Feb 22, 2013
7b6ee72
Spinner: Call _stop() on blur. Fixes #9112 - Spinner keeps changing a…
scottgonzalez Feb 22, 2013
9fed978
Autocomplete demo (Combobox): Don't highlight term matches. Fixes #90…
scottgonzalez Feb 19, 2013
98d37bf
Autocomplete demo (Combobox): Rename selected event to select.
scottgonzalez Feb 19, 2013
8ea93ea
Autocomplete demo (Combobox): Split code into smaller functions.
scottgonzalez Feb 19, 2013
d597cb5
Upgrade mousewheel to 3.1.0.
scottgonzalez Feb 22, 2013
59b172a
Autocomplete: Set isNewMenu flag on every suggestion. Fixes #9118 - A…
scottgonzalez Feb 25, 2013
0519147
Position: Fix orientation check for scrollbar widths. Fixes #8763 - P…
scottgonzalez Feb 26, 2013
672960a
Droppable: Changed drop event to loop over a copied array instead of …
voithos Feb 24, 2013
8464414
Droppable tests: Cleanup.
scottgonzalez Feb 26, 2013
ff96d57
Effects: Delegate to core show/hide when the element is already in th…
scottgonzalez Feb 26, 2013
d16feb3
Accordion demo: Clean up hoverintent implementation to avoid using jQ…
scottgonzalez Feb 27, 2013
3a6e43c
Effects: Handle the .hide/show/toggle( options ) signatures from core…
scottgonzalez Feb 28, 2013
7ef3925
Sortable: Adding a min-width to the body on the portlet demo. Fixed …
tjvantoll Feb 28, 2013
e519f84
Slider tests: Don't use .on().
scottgonzalez Mar 2, 2013
5c5a3cc
Slider tests: Use ui-slider not uiSlider for data key.
scottgonzalez Mar 2, 2013
5a3d8f4
Draggable Tests: Add test coverage for supported options
mikesherov Jan 12, 2013
d3abe08
Draggable Tests: Style Sweep
mikesherov Mar 4, 2013
d8d7484
Draggable Tests: Fix snap test failures in IE8
mikesherov Mar 4, 2013
46738a0
Draggable Tests: Fix containment tests
mikesherov Mar 4, 2013
fbe0720
Sortable: Copy the src of the original item when creating a placehold…
scottgonzalez Mar 7, 2013
71342ff
Sortable tests: Added alt attributes to images.
scottgonzalez Mar 7, 2013
9c225ad
Draggable: Fix border containment. Fixed #5569 - Draggable: Containme…
tjvantoll Jan 26, 2013
9e35b18
Draggable: Account for descendants in handle.
scottgonzalez Mar 8, 2013
dec89db
Removed guard against duplicate loading. Use safe references to origi…
scottgonzalez Mar 8, 2013
9ddeec0
Sortable: Skip items that are not at the same line as the cursor when…
zhizhangchen Feb 16, 2013
6d89ee7
Sortable: Skip triggering over event if it's alreay over the continer…
zhizhangchen Feb 16, 2013
67e420d
Sortable Tests: Add tests to support #9041 and #8792
mikesherov Mar 8, 2013
75cb47a
Draggable tests: Don't use .on().
scottgonzalez Mar 9, 2013
edf0377
CSS Framework: Add ui-icon-blank class for an icon with no image. Fix…
scottgonzalez Mar 11, 2013
eb9068a
Widget: Stop setting ui-state-disabled and aria by default on setting…
mikesherov Mar 12, 2013
81da37e
Build: Migrate to grunt 0.4. Rename to Gruntfile, upgrade to newer gr…
jzaefferer Dec 21, 2012
cc0ecac
Build: Switch from grunt-css to the equivalent grunt-contrib tasks
jzaefferer Mar 11, 2013
ca44da2
Build: Don't call DB's grunt-prepare task, not needed anymore
jzaefferer Mar 12, 2013
b34ba84
Build: Update to grunt-contrib-qunit 0.2.0 to get latest PhantomJS
jzaefferer Mar 12, 2013
b68ca0c
Build: Fix the key for the 'all' subtask for compare_size. Stills nee…
jzaefferer Mar 12, 2013
ea81b27
Upgrade to grunt-git-authors 1.2.0.
scottgonzalez Mar 12, 2013
f9c8755
Updated AUTHORS.txt.
scottgonzalez Mar 12, 2013
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* text=auto
6 changes: 6 additions & 0 deletions .mailmap
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Kris Borchers <kris.borchers@gmail.com>
Kris Borchers <kris.borchers@gmail.com> <k_borchers@yahoo.com>
Corey Frang <gnarf@gnarf.net>
Maggie Costello Wachs <fg.maggie@gmail.com> maggiewachs <maggie@filamentgroup.com>
Richard Worth <rdworth@gmail.com>
Jörn Zaefferer <joern.zaefferer@gmail.com>
34 changes: 33 additions & 1 deletion AUTHORS.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Authors ordered by first contribution
Authors ordered by first contribution
A list of current team members is available at http://jqueryui.com/about

Paul Bakaus <paul.bakaus@googlemail.com>
Expand Down Expand Up @@ -208,3 +208,35 @@ Sindre Sorhus <sindresorhus@gmail.com>
Bernhard Sirlinger <bernhard.sirlinger@tele2.de>
Jared A. Scheel <jared@jaredscheel.com>
Rafael Xavier de Souza <rxaviers@gmail.com>
John Chen <zhang.z.chen@intel.com>
Dale Kocian <dale.kocian@gmail.com>
Mike Sherov <mike.sherov@gmail.com>
Andrew Couch <andy@couchand.com>
Marc-Andre Lafortune <github@marc-andre.ca>
Nate Eagle <nate.eagle@teamaol.com>
David Souther <davidsouther@gmail.com>
Mathias Stenbom <mathias@stenbom.com>
Avinash R <nashpapa@gmail.com>
Sergey Kartashov <ebishkek@yandex.ru>
Ethan Romba <ethanromba@gmail.com>
Cory Gackenheimer <cory.gack@gmail.com>
Juan Pablo Kaniefsky <jpkaniefsky@gmail.com>
Roman Salnikov <bardt.dz@gmail.com>
Anika Henke <anika@selfthinker.org>
Samuel Bovée <samycookie2000@yahoo.fr>
Fabrício Matté <ult_combo@hotmail.com>
Viktor Kojouharov <vkojouharov@gmail.com>
Pawel Maruszczyk <lord_t@o2.pl>
Pavel Selitskas <p.selitskas@gmail.com>
Bjørn Johansen <bjorn.johansen@metronet.no>
Matthieu Penant <thieum22@hotmail.com>
Dominic Barnes <dominic@dbarnes.info>
David Sullivan <david.sullivan@gmail.com>
Thomas Jaggi <thomas.jaggi@gmail.com>
Vahid Sohrabloo <vahid4134@gmail.com>
Travis Carden <travis.carden@gmail.com>
Bruno M. Custódio <bruno@brunomcustodio.com>
Nathanael Silverman <nathanael.silverman@gmail.com>
Christian Wenz <christian@wenz.org>
Steve Urmston <steve@urm.st>
Zaven Muradyan <megalivoithos@gmail.com>
205 changes: 205 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,205 @@
# Contributing to jQuery UI

1. [Getting Involved](#getting-involved)
2. [Discussion](#discussion)
3. [How To Report Bugs](#how-to-report-bugs)
4. [jQuery UI Coding Standards](#jquery-ui-coding-standards)
5. [Tips For Bug Patching](#tips-for-bug-patching)



## Getting Involved

There are a number of ways to get involved with the development of jQuery UI. Even if you've never contributed code to an Open Source project before, we're always looking for help identifying bugs, writing and reducing test cases and documentation.

This is the best way to contribute to jQuery UI. Please read through the full guide detailing [How to Report Bugs](#how-to-report-bugs).

## Discussion

### Forum and IRC

The jQuery UI development team frequently tracks posts on the [Developing jQuery UI Forum](http://forum.jquery.com/developing-jquery-ui). If you have longer posts or questions please feel free to post them there. If you think you've found a bug please [file it in the bug tracker](#how-to-report-bugs).

Additionally most of the jQuery UI development team can be found in the [#jqueryui-dev](http://webchat.freenode.net/?channels=jqueryui-dev) IRC channel on irc.freenode.net.

### Weekly Status Meetings

Every week (unless otherwise noted) the jQuery UI dev team has a meeting to discuss the progress of current work and to bring forward possible new blocker bugs for discussion.

The meeting is held in the [#jquery-meeting](http://webchat.freenode.net/?channels=jquery-meeting) IRC channel on irc.freenode.net at [Noon EST](http://www.timeanddate.com/worldclock/fixedtime.html?month=1&day=17&year=2011&hour=12&min=0&sec=0&p1=43) on Wednesdays.

Past Meeting Notes:
[2008 - 2011](https://docs.google.com/spreadsheet/ccc?key=0AusvKVL7jmFUcHVBQk9tMUxkRGl0emVwZGdLd0QtUlE),
[2012 - current](https://docs.google.com/spreadsheet/ccc?key=0ArIM4UVbwE-3dFg1T0k4VlE1bF82Nm9tbW90cVNxN0E)


## How to Report Bugs

### Make sure it is a jQuery UI bug

Many bugs reported to our bug tracker are actually bugs in user code, not in jQuery UI code. Keep in mind that just because your code throws an error and the console points to a line number inside of jQuery or jQuery UI, this does *not* mean the bug is a jQuery UI bug.

If you are new to jQuery and/or jQuery UI, it is usually a much better idea to ask for help first in the [Using jQuery Forum](http://forum.jquery.com/using-jquery), the [Using jQuery UI Forum](http://forum.jquery.com/using-jquery-ui) or the [jQuery IRC channel](http://webchat.freenode.net/?channels=%23jquery). You will get much quicker support, and you will help avoid tying up the jQuery UI team with invalid bug reports. These same resources can also be useful if you want to confirm that your bug is indeed a bug in jQuery UI before filing any tickets.


### Disable any browser extensions

Make sure you have reproduced the bug with all browser extensions and add-ons disabled, as these can sometimes cause things to break in interesting and unpredictable ways. Try using incognito, stealth or anonymous browsing modes.


### Try the latest version of jQuery UI

Bugs in old versions of jQuery UI may have already been fixed. In order to avoid reporting known issues, make sure you are always testing against the latest stable release.

### Try an older version of jQuery UI

Sometimes, bugs are introduced in newer versions of jQuery UI that do not exist in previous versions. When possible, it can be useful to try testing with an older release.

### Reduce, reduce, reduce!

When you are experiencing a problem, the most useful thing you can possibly do is to [reduce your code](http://webkit.org/quality/reduction.html) to the bare minimum required to reproduce the issue. This makes it *much* easier to isolate and fix the offending code. Bugs that are reported without reduced test cases generally take much longer to fix than bugs that are submitted with them, so you really should try to do this if at all possible.

## jQuery UI Coding Standards

See: [jQuery UI Coding Standards](http://wiki.jqueryui.com/w/page/12137737/Coding%20standards)

## Tips For Bug Patching


### Environment: localhost w/ PHP, Node & Grunt

jQuery UI uses node & gruntjs to automate the building and validation of source code.

Some tests depend on PHP running locally, so make sure you have the following installed:

* Some kind of localhost server program that supports PHP (any will do)
* Node.js
* NPM (comes with the latest version of Node.js)
* Grunt (install with: `npm install grunt -g`


Maintaining a list of platform specific instructions is outside of the scope of this document and there is plenty of existing documentation for the above technologies.


### Build a Local Copy of jQuery UI

Create a fork of the jQuery UI repo on github at http://github.com/jquery/jquery-ui

Change directory to your web root directory, whatever that might be:

```bash
$ cd /path/to/your/www/root/
```

Clone your jQuery UI fork to work locally

```bash
$ git clone git@github.com:username/jquery-ui.git
```

Change directory to the newly created dir jquery-ui/

```bash
$ cd jquery-ui
```

Add the jQuery master as a remote. I label mine "upstream"

```bash
$ git remote add upstream git://github.com/jquery/jquery-ui.git
```

Get in the habit of pulling in the "upstream" master to stay up to date as jQuery UI receives new commits

```bash
$ git pull upstream master
```

To lint the JavaScript, HTML, and CSS, as well as run a smoke test in PhantomJS, run grunt:

```bash
$ grunt
```

To run the tests for a specific plugin in your browser, open the approriate file from the /tests/unit/ directory, for example: http://localhost/tests/unit/accordion/accordion.html. The domain will be dependent on your local server configuation; if there is a port, be sure to include it.

Success! You just tested jQuery UI!


### Fix a bug from a ticket filed at bugs.jqueryui.com:

**NEVER write your patches to the master branch** - it gets messy (I say this from experience!)

**ALWAYS USE A "TOPIC" BRANCH!** Like so (#### = the ticket #)...

Make sure you start with your up-to-date master:

```bash
$ git checkout master
```

Create and checkout a new branch that includes the ticket #

```bash
$ git checkout -b bug_####

# ( Explanation: this useful command will:
# "checkout" a "-b" (branch) by the name of "bug_####"
# or create it if it doesn't exist )
```

Now you're on branch: bug_####

Determine the file you'll be working in...

Open up the corresponding /tests/unit/?????.js and add the initial failing unit tests. This may seem awkward at first, but in the long run it will make sense. To truly and efficiently patch a bug, you need to be working against that bug.

Next, open the source files and make your changes

Run http://localhost/tests/unit/???? --> **ALL TESTS MUST PASS**

Once you're satisfied with your patch...

Stage the files to be tracked:

```bash
$ git add filename
# (you can use "git status" to list the files you've changed)
```


( I recommend NEVER, EVER using "git add . " )

Once you've staged all of your changed files, go ahead and commit them

```bash
$ git commit -m "Component: Brief description of fix. Fixes #0000 - Ticket description."
```

See the [commit message style guide](http://wiki.jqueryui.com/w/page/25941597/Commit%20Message%20Style%20Guide) for more details on how to format your commit message.

For a multiple line commit message, leave off the `-m "description"`.

You will then be led into vi (or the text editor that you have set up) to complete your commit message.

Then, push your branch with the bug fix commits to your github fork

```bash
$ git push origin -u bug_####
```

Before you tackle your next bug patch, return to the master:

```bash
$ git checkout master
```



### jQuery UI supports the following browsers:

* Chrome Current-1
* Safari Current-1
* Firefox Current-1
* Opera Current-1
* IE 7+
Loading