Skip to content

modernize sunrise - replace wpmu_current_site #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

modernize sunrise - replace wpmu_current_site #378

wants to merge 1 commit into from

Conversation

Ipstenu
Copy link

@Ipstenu Ipstenu commented Oct 9, 2015

This should fix #303 - resolving the various undefined errors and removing the deprecation warning.

I tested this locally and using your Vagrant setup and it appears to work without throwing errors. I pulled the code from WPMU Domain Mapping ( see https://plugins.trac.wordpress.org/browser/wordpress-mu-domain-mapping/trunk/sunrise.php ) which has to do some odd things since get_current_site doesn't exist when we're calling sunrise.php

Needs more testing in your environment, but I think this may work.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@gnarf
Copy link
Member

gnarf commented Oct 9, 2015

Thanks @Ipstenu - can you go sign the CLA? I'd love to land this! 😍

I tested this locally and using your Vagrant setup and it appears to work without throwing errors. I pulled the code from WPMU Domain Mapping ( see https://plugins.trac.wordpress.org/browser/wordpress-mu-domain-mapping/trunk/sunrise.php ) which has to do some odd things since `get_current_site` doesn't exist when we're calling sunrise.php

Needs more testing in your environment, but I think this may work.
@gnarf
Copy link
Member

gnarf commented Oct 9, 2015

Just tested this on WP 4.3.1 - still get a "Something went very wrong when trying to install blog.jquery.com as site -2. Find nacin." when trying to install for the first time.

@gnarf
Copy link
Member

gnarf commented Oct 13, 2015

Thanks so much for looking at this - I merged #379 after testing in 4.3.1. ♥

@gnarf gnarf closed this Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Replace wpmu_current_site() in sunrise.php
3 participants