Update sunrise and allow newer versions of WordPress to work #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of WordPress 3.9, `wpmu_current_site()` was deprecated and not left with a full, working replacement. We know that this environment relies on a single multisite network and can populate a network object accordingly. If for some reason multiple networks are used in the future, check to make sure the populated site object matches the network as expected.
During initial installation, it's possible for the `site_admins` meta key to be left blank and for a new meta key/value store to be created after that one is misread. We should delete this option during installation before recreating it with the current user performing the install.
A filter is added to make all URLs protocol relative, but our handling of these in WordPress core for updates doesn't work. It's possible this works in future versions of WordPress, but in my testing while upgrading from 3.8.1 to 4.3.1, things stood still. :)
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
Member
|
Just tested, everything looks great - Thanks so much! |
This was referenced Oct 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #303:
site_adminsnetwork option may not be properly set during installation locally.downloads.wordpress.orgURLs to survive the protocol relative filter so that local updates will work nicely.This takes a slightly different approach from @Ipstenu in #378 as there are quite a few gotchas hanging out there when running this outside of the Vagrant environment and/or when installing and upgrading.
There's probably room for future improvement, especially once the Vagrant box has been updated to use a newer version of WordPress by default. We could then rewrite a bit more and make a few more assumptions about the environment. This should work as a pretty good stop-gap in the meantime.
I've tested: