Added few more types. #370
Conversation
|
@scottgonzalez Bump! :) |
| @@ -28,6 +28,10 @@ typeof myArray; // "object" -- Careful! | |||
| typeof myString; // "string" | |||
| typeof myNumber; // "number" | |||
| typeof null; // "object" -- Careful! | |||
| typeof undefined; // "undefined" | |||
| typeof meh; // "undefined" -- undefined variable. | |||
| typeof /re/ // 'function'; -- Chrome and 'object' in Firefox. | |||
There was a problem hiding this comment.
Perhaps we should just say "function" or "object" depending on environment. It's not great to call out 2 browsers when there are so many.
There was a problem hiding this comment.
Also, since everything else is checking against a variable, we should follow that pattern here too.
There was a problem hiding this comment.
@scottgonzalez Will rm the browser names and instead of /re/ it must be?
There was a problem hiding this comment.
myRegExp, and assigned above with everything else.
|
@scottgonzalez Made the suggested changes :) |
|
You're still not checking against a variable. Do you not see the discrepancy between this check and every other check? |
| @@ -28,6 +28,10 @@ typeof myArray; // "object" -- Careful! | |||
| typeof myString; // "string" | |||
| typeof myNumber; // "number" | |||
| typeof null; // "object" -- Careful! | |||
| typeof undefined; // "undefined" | |||
| typeof meh; // "undefined" -- undefined variable. | |||
| typeof /myRegExp/; // 'function' or 'object' depending on environment. | |||
There was a problem hiding this comment.
Please update this to use double quotes to match the surrounding code.
There was a problem hiding this comment.
Done, sorry about that!
|
You're still not defining the variable. |
|
@scottgonzalez There is some confusion here....you want me to have |
|
Yes, exactly like all of the other checks. But I would use |
|
@scottgonzalez Duh! I don't know why I could not get it! Anyway have done it, thanks! |
|
Thanks, landed in 4df62ec. |
|
@scottgonzalez Thanks, the page needs some more time to reflect? |
|
The site hasn't been deployed yet. We deploy on tags, not on every commit. |
|
Oh, OK...I was under the notation that the md files are being picked up form the repo directly! |
|
Nope, we've got an awesomely complex deployment process. The sites are actually WordPress sites. We deploy to stage on every commit to master (just add a "stage." prefix to the domain), you're even automatically added to the list of contributors on that page. |
|
@scottgonzalez Wow! Awesome 👍 Is the deployment process documented ? |
|
Kool, thank you! :) |
No description provided.