Added few more type tests. #282
Conversation
| In comprasion to other programming languages Objects in JavaScript are similar to : | ||
|
|
||
| * Dictionaries in Python. | ||
|
|
There was a problem hiding this comment.
This list shouldn't have blank lines in between the items, and does not need periods at the end of each item.
|
@ajpiano Done with the changes as per the need. :) |
| @@ -7,6 +7,14 @@ attribution: | |||
| --- | |||
| Objects contain one or more key-value pairs. The key portion can be any string. The value portion can be any type of value: a number, a string, an array, a function, or even another object. When one of these values is a function, it’s called a method of the object. Otherwise, they are called properties. | |||
|
|
|||
| In comprasion to other programming languages Objects in JavaScript are similar to : | |||
There was a problem hiding this comment.
Adding some comments on these changes, if you don't mind.
- "comprasion" should be "comparison"
- "Objects" should be "objects"
- There shouldn't be a space before the colon
| @@ -7,6 +7,14 @@ attribution: | |||
| --- | |||
| Objects contain one or more key-value pairs. The key portion can be any string. The value portion can be any type of value: a number, a string, an array, a function, or even another object. When one of these values is a function, it’s called a method of the object. Otherwise, they are called properties. | |||
|
|
|||
| In comparsion to other programming languages objects in JavaScript are similar to: | |||
There was a problem hiding this comment.
"comparsion" should still be "comparison" :)
There was a problem hiding this comment.
Duh! I'm dyslexic 👨
|
I think this looks good now! Sorry for all the nitpicks :) |
|
@alimony No problem, from the next PR it shall be better, I appreciate your effort for perfection. Thanks! |
|
Well, I have no authority here, I'm just a contributor like you, happening to be looking at style coherence stuff at the moment. |
|
@ajpiano meow? |
| @@ -7,6 +7,14 @@ attribution: | |||
| --- | |||
| Objects contain one or more key-value pairs. The key portion can be any string. The value portion can be any type of value: a number, a string, an array, a function, or even another object. When one of these values is a function, it’s called a method of the object. Otherwise, they are called properties. | |||
|
|
|||
| In comparison to other programming languages objects in JavaScript are similar to: | |||
|
@hemanth Can you sign the CLA so we can finish the review of this code? You'll also need to update your git config to contain your full name and email address. See https://help.github.com/articles/set-up-git#set-up-git for details. |
|
@scottgonzalez Sure, my git config is set. Will sign the CLA and push the comma soon! 👍 |
|
@hemanth Is your legal name really Hemanth.HM? |
|
@scottgonzalez Yes :) |
| 99999: 789 | ||
| validIdentifier: 123, | ||
| "some string": 456, | ||
| 99999: 789 |
There was a problem hiding this comment.
The spacing shouldn't have changed here.
There was a problem hiding this comment.
Actually, it's hard to tell what changed here. It looks like you're out-of-date with master.
|
Can you rebase this? It'd also be good to squash this into just two commits (one per file). |
|
@scottgonzalez This P.R has got really messy, will close and send new ones afresh? |
|
That sounds good. Thanks @hemanth. |
|
@scottgonzalez New P.Rs have been pushed, please have a look at #370 and #371 thank you! |
No description provided.