Skip to content

fix broken chaining in basic-plugin-creation.md #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix broken chaining in basic-plugin-creation.md #399

wants to merge 1 commit into from

Conversation

janusschmidt
Copy link
Contributor

Unless you actually want the side-effect of filtering, so only a tags are left, the examples are wrong.

Unless you actually want the side-effect of filtering, so only "a" tags are left, the examples are wrong.
@eddiemonge
Copy link
Contributor

@janusschmidt Could you please sign our CLA and update your git config to include your real name?

@janusschmidt
Copy link
Contributor Author

I've signed the CLA.
How do I get a name change in my local git configuration into the pull
request?
On 6 Sep 2013 00:59, "Eddie Monge Jr." notifications@github.com wrote:

@janusschmidt https://github.com/janusschmidt Could you please sign our
CLA http://contribute.jquery.org/CLA/ and update your git config to
include your real name?


Reply to this email directly or view it on GitHubhttps://github.com//pull/399#issuecomment-23908000
.

@janusschmidt
Copy link
Contributor Author

Oh wait.
My username "Janus Schmidt" is set allright on the commit allready.
If you look in github it shows my github username "janusschmidt". But if i
clone my learn.jquery repository and look at my commit it's correctly
authered by "Janus Schmidt".

I guess it's standard for you to ask for both CLA and real name if one is
missing?

Hope everything is correct now.
(It was easier fixing the code than getting the paperpushing stuff in order
;-) )

Janus

On Fri, Sep 6, 2013 at 12:59 AM, Eddie Monge Jr.
notifications@github.comwrote:

@janusschmidt https://github.com/janusschmidt Could you please sign our
CLA http://contribute.jquery.org/CLA/ and update your git config to
include your real name?


Reply to this email directly or view it on GitHubhttps://github.com//pull/399#issuecomment-23908000
.

arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants