Skip to content

fix broken chaining in basic-plugin-creation.md #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janusschmidt wants to merge 1 commit into from
Closed

fix broken chaining in basic-plugin-creation.md #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions page/plugins/basic-plugin-creation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,11 @@ Here's an example of a small plugin using some of the techniques we've discussed

$.fn.showLinkLocation = function() {

return this.filter( "a" ).each(function() {
this.filter( "a" ).each(function() {
$( this ).append( " (" + $( this ).attr( "href" ) + ")" );
});

return this;

};

Expand All @@ -216,9 +218,11 @@ Our plugin can be optimized though:

$.fn.showLinkLocation = function() {

return this.filter( "a" ).append(function() {
this.filter( "a" ).append(function() {
return " (" + this.href + ")";
});

return this;

};

Expand Down