Make the example more concrete #534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a student, I want to copy/paste the example and try it. By adding a definition of the CSS for the on and off class, and by adding text which can be clicked on, the example becomes easily runnable.
| @@ -55,10 +60,10 @@ $( ".switch, .clapper" ).click(function() { | |||
| }); | |||
| ``` | |||
|
|
|||
| With custom events, your code might look more like this: | |||
| With custom events, we can define our own events. Then your code might look more like this: | |||
There was a problem hiding this comment.
I would prefer we reword this a bit more and also stuck with the shorter changeState:
We can instead use a custom event, like
changeStateand our code would look more like this:
|
If you're still interested in seeing this change through, could you look at my suggestions. Otherwise I'll probably make the changes myself in a few weeks. |
|
@githubshrek Could you include your real name in your git config? |
|
OK, added my real name. |
| <style> | ||
| .on { background-color: yellow; } | ||
| .off { background-color: black; color: white; } | ||
| </style> |
There was a problem hiding this comment.
let us handle this together with #535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a student, I want to copy/paste the example and try it. By adding a definition of the CSS for the on and off class, and by adding text which can be clicked on, the example becomes easily runnable. Also, by choosing a more obviously non-standard event name like "changeTheLightState", then it is clearer to the student that this is something custom.