Make the example runnable #535
Conversation
The proposed changes, together with the style sheet suggestion proposed in the previous proposed change (and shown below), means that the example moves from being abstract, and students can directly copy/paste the example and see it work.
<style>
.on { background-color: yellow; }
.off { background-color: black; color: white; }
</style>
| <div class="clapper"></div> | ||
| <div class="lightbulb on">Kitchen light</div> | ||
| <div class="switch">Kitchen switch 1</div> | ||
| <div class="switch">Kitchen switch 1</div> |
There was a problem hiding this comment.
ping @githubshrek. This PR needs some updates.
|
@githubshrek Same thing over here. You must include your real name in your git config. |
|
This PR highly overlaps with #534. Let us handle that in one PR. |
|
@githubshrek Hey! We asked for the CLA multiple times and can't merge without a signature. I'm going to close this due to inactivity. It doesn't really make sense to keep old PRs open for really long. Hope you'll be able to come back to this and we can reopen. |
|
I thought I already signed whatever you wanted. You tell me I have to sign something, but give me not a clue where I should go to sign it. I have no idea where to go. |
|
@githubshrek You have a signature on our file but will need to include your real name in your git config. We told you that on all your other PRs as well. Anyways, glad you responded now :) Could you add your real name and update the PR with the things we commented? |
|
My Git profile has had my real name ever since you asked for it. If you want me to put my real name elsewhere, please tell me where, and how I do that. |
We were talking about your actual git config (not your GitHub profile), which has Run that on the branch you created for the PR and and fill in with your own details of course. These details should match the ones you signed the CLA with. After changing it you will need to force push your commit to your branch. |
|
ping @githubshrek? It doesn't seem to have worked? If you have any issues, feel free to contact me on Freenode IRC as arthurvr. Would love to be able to land this change, it's been open for way too long. |
|
Hi, I have no idea how to do any of what you're talking about. I don't have a regards, Hugh Prior On 17 April 2015 at 20:31, Arthur Verschaeve notifications@github.com
|
|
@arthurvr This was discussed today with the legal team. We can land the PR and change the author's name using --author |
The proposed changes, together with the style sheet suggestion proposed in the previous proposed change (and shown below), means that the example moves from being abstract, and students can directly copy/paste the example and see it work.
<style>
.on { background-color: yellow; }
.off { background-color: black; color: white; }
</style>
Closes #535.
The proposed changes, together with the style sheet suggestion proposed in the previous proposed change (and shown below), means that the example moves from being abstract, and students can directly copy/paste the example and see it work.