[UI 1.12] jQuery UI: Article on the classes option#574
Conversation
There was a problem hiding this comment.
First sentence, "...works on any other..." need the word 'on' in that sentence.
|
This is an awesome start! |
There was a problem hiding this comment.
checkout -> check out, unless you actually want them to clone and checkout the code.
|
@tjvantoll Wanne update the PR a little? |
|
@arthurvr I'm waiting for the |
|
I think the API is now final, could update this. |
|
I addressed all comments and finished the section on custom widgets. This is ready for a review (although note that this shouldn't go live until jQuery UI 1.12 does). |
There was a problem hiding this comment.
This is not entirely true it maps structural class names to theme class's ( both custom and built in ). You are also doing more then just making the dialog red here you are also removing the rounded corners.
|
Just as a general comment on the last half of this article on custom widgets. I think that if we are going to get into the use of the new methods in your own widgets we should get into more detail and fully explain their use ( and probably mention some common pitfalls people will run into ). Otherwise i think we should stick to explaining how to use the option and leave custom widgets for another more in depth article or just to the api site. |
WIP. I need to make another pass at this after we decide if we're moving forward with
_addClass()and_removeClass().