Skip to content

Conversation

@tjvantoll
Copy link
Member

WIP. I need to make another pass at this after we decide if we're moving forward with _addClass() and _removeClass().

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First sentence, "...works on any other..." need the word 'on' in that sentence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not "on", but "like".

@RedWolves
Copy link
Member

This is an awesome start!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkout -> check out, unless you actually want them to clone and checkout the code.

@arthurvr
Copy link
Member

arthurvr commented Jan 5, 2015

@tjvantoll Wanne update the PR a little?

@tjvantoll
Copy link
Member Author

@arthurvr I'm waiting for the _addClass(), _removeClass(), and _toggleClass() APIs to finalize before addressing the comments and finishing this article.

@jzaefferer
Copy link
Member

I think the API is now final, could update this.

@tjvantoll
Copy link
Member Author

I addressed all comments and finished the section on custom widgets. This is ready for a review (although note that this shouldn't go live until jQuery UI 1.12 does).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not entirely true it maps structural class names to theme class's ( both custom and built in ). You are also doing more then just making the dialog red here you are also removing the rounded corners.

@arschmitz
Copy link
Member

Just as a general comment on the last half of this article on custom widgets. I think that if we are going to get into the use of the new methods in your own widgets we should get into more detail and fully explain their use ( and probably mention some common pitfalls people will run into ). Otherwise i think we should stick to explaining how to use the option and leave custom widgets for another more in depth article or just to the api site.

@gnarf gnarf changed the title jQuery UI: Article on the classes option—new to jQuery UI 1.12 [UI 1.12] jQuery UI: Article on the classes option Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

7 participants