Issue #744 missing text#748
Merged
Merged
Conversation
Fixed "Encapsulation" section which had missing text in Pages/Code-Organization/Contents
This reverts commit 5037cca.
Component: Content file under Code-Organization Replaced incomplete text. Fixes jquery#744
|
|
Krinkle
approved these changes
Mar 26, 2023
Krinkle
pushed a commit
that referenced
this pull request
Apr 9, 2024
Fixed "Encapsulation" section which had missing text. The incomplete "is sufficient to lend" sentence has been here as early as the first 2011 commit of the book that the site was based on: https://github.com/rmurphey/jqfundamentals/blob/55eb9dd5d5779b884fdafbe6673b04a5d0c97733/book/part3-advanced-topics/ch10-code-organization.html Closes #748. Fixes #744.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the missing text to Pages/Code-Organization/contents.md file, however I did not set up local WordPress instance to test my changes. Thanks!