fixes #12492, is(:focus) fails in Chrome#149
Closed
mikesherov wants to merge 3 commits intojquery:masterfrom
Closed
fixes #12492, is(:focus) fails in Chrome#149mikesherov wants to merge 3 commits intojquery:masterfrom
mikesherov wants to merge 3 commits intojquery:masterfrom
Conversation
sizzle.js
Outdated
Member
There was a problem hiding this comment.
Did we void the rule about single quoted arguments having no surrounding spaces? I have been leaving them out.
Member
|
We have a |
Member
Author
|
It wasn't failing. |
Member
Author
|
style nits fixed. I still don't know why the units weren't failing. Perhaps it's only on user generated focus events instead of generated ones, but I confirmed in the fiddle on the original ticket that this fixed it. |
Member
|
Thanks Mike. |
Member
|
Something's funky here. Can you rebase on master? |
markelog
pushed a commit
to markelog/sizzle
that referenced
this pull request
May 26, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue coming from http://bugs.jquery.com/ticket/12492
I couldn't find a suitable unit test. @timmywil, any suggestions?