Skip to content

fixes #12492, is(:focus) fails in Chrome #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikesherov wants to merge 3 commits into from
Closed

fixes #12492, is(:focus) fails in Chrome #149

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26853ee
fixes #12492, is(:focus) fails in Chrome
mikesherov Sep 9, 2012
0eb0e39
style
mikesherov Sep 10, 2012
893aa32
rebased incorrectly
mikesherov Sep 11, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions sizzle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,11 +1373,16 @@ if ( document.querySelectorAll ) {
oldSelect = select,
rescape = /'|\\/g,
rattributeQuotes = /\=[\x20\t\r\n\f]*([^'"\]]*)[\x20\t\r\n\f]*\]/g,
rbuggyQSA = [],

// qSa(:focus) reports false when true (Chrome 21),
// A support test would require too much code (would include document ready)
rbuggyQSA = [":focus"],

// matchesSelector(:focus) reports false when true (Chrome 21),
// matchesSelector(:active) reports false when true (IE9/Opera 11.5)
// A support test would require too much code (would include document ready)
// just skip matchesSelector for :active
rbuggyMatches = [":active"],
rbuggyMatches = [ ":active", ":focus" ],
matches = docElem.matchesSelector ||
docElem.mozMatchesSelector ||
docElem.webkitMatchesSelector ||
Expand Down Expand Up @@ -1424,7 +1429,8 @@ if ( document.querySelectorAll ) {
}
});

rbuggyQSA = rbuggyQSA.length && new RegExp( rbuggyQSA.join("|") );
// rbuggyQSA always contains :focus, so no need for a length check
rbuggyQSA = /* rbuggyQSA.length && */ new RegExp( rbuggyQSA.join("|") );

select = function( selector, context, results, seed, xml ) {
// Only use querySelectorAll when not filtering,
Expand Down Expand Up @@ -1490,7 +1496,7 @@ if ( document.querySelectorAll ) {
} catch ( e ) {}
});

// rbuggyMatches always contains :active, so no need for a length check
// rbuggyMatches always contains :active and :focus, so no need for a length check
rbuggyMatches = /* rbuggyMatches.length && */ new RegExp( rbuggyMatches.join("|") );

Sizzle.matchesSelector = function( elem, expr ) {
Expand Down