Add tags to omnicompletion#179
Closed
anjiro wants to merge 8 commits intolervag:masterfrom
anjiro:master
Closed
Conversation
`l:origin[1]` is the results of `getpos(.)`, not just a line number, causing an error on template rendering
Owner
|
I'll be happy to consider this PR, but please: the PR itself contains commits already merged. Can you please rebase your work on top of the current master and only propose new commits? A simple way to do it is to fork the latest master, then just copy your files and commit them either all in one or with some logical commits - feel free to ask if you want more help with it. |
Contributor
Author
|
Yes, will do that. |
Owner
|
#180 replaces this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It’s got a bit of a hack to avoid matching the end-of-tag marker when in
findstartmode, but it seems to work in my basic testing. It does depend ong:wiki_tags_format_patternhaving a\ze, but since that’s the default and how it’s documented it should probably be ok.