Skip to content

Add tag completion#180

Closed
anjiro wants to merge 4 commits intolervag:masterfrom
anjiro:tagcomplete
Closed

Add tag completion#180
anjiro wants to merge 4 commits intolervag:masterfrom
anjiro:tagcomplete

Conversation

@anjiro
Copy link
Copy Markdown
Contributor

@anjiro anjiro commented Jul 24, 2021

It’s got a bit of a hack to avoid matching the end-of-tag marker when in findstart mode, but it seems to work in my basic testing. It does depend on g:wiki_tags_format_pattern having a \ze, but since that’s in the default pattern and is featured in the documentation examples, it seems likely to be fine.

@lervag
Copy link
Copy Markdown
Owner

lervag commented Jul 24, 2021

Thanks! The code looks good. It would be nice if you could also add:

  • Some documentation (in doc/wiki.txt in the completion section).
  • Either one or more simple tests (see test/test-complete/test-wikilinks.vim for an example), or as a minimum some example files in test/wiki-basic or similar, which I can use to add the tests myself.

@anjiro
Copy link
Copy Markdown
Contributor Author

anjiro commented Jul 25, 2021

Added docs, will look at tests in the next few days.

@anjiro
Copy link
Copy Markdown
Contributor Author

anjiro commented Jul 31, 2021

I added some extra tags to to tagged.wiki to enable basic testing. I’m doing almost all of my work with iVim on iOS at the moment so implementing a full test is a bit too complex.

lervag added a commit that referenced this pull request Aug 6, 2021
@lervag
Copy link
Copy Markdown
Owner

lervag commented Aug 6, 2021

Thanks! I've added test and made some minor modifications.

@lervag lervag closed this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants