Fix animation-name check for old browsers #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, or style property
|
Thanks! |
emannuel
pushed a commit
to pathable/css-element-queries
that referenced
this pull request
Jun 25, 2019
- don't explode if an old browser can't provide element, computed style, or style property (marcj#241)
emannuel
added a commit
to pathable/css-element-queries
that referenced
this pull request
Jun 26, 2019
…-fix Cherry-pick: don't explode if an old browser can't provide element, computed style, or style property (marcj#241)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to a bug tracker of a developing app, old browsers like Safari of IOS8 or Chrome of Android5 could return
nullinstead of requested style property. This patch brings additional checks.Screenshot from our bug tracer:
