Skip to content

Cherry-pick: don't explode if an old browser can't provide element, computed style, or style property (#241) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

emannuel
Copy link

@emannuel emannuel commented Jun 25, 2019

Cherry-picking a commit from the original repository that fixes some issues, including the crash on firefox that we were receiving on the admin.

Original commit: marcj@da5f446

 - don't explode if an old browser can't provide element, computed style, or style property (marcj#241)
@emannuel emannuel added the bug Something isn't working label Jun 25, 2019
@emannuel emannuel requested a review from nachocodoner June 25, 2019 15:54
@emannuel emannuel self-assigned this Jun 25, 2019
Copy link

@nachocodoner nachocodoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to upgrade the version, publish to npm from pathable-fixes branch, and also update the version in pathable vendor dependencies.

@emannuel emannuel merged commit 5c6055a into pathable-fixes Jun 26, 2019
@emannuel emannuel deleted the feature/cherry-pick-firefox-issue-fix branch June 26, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants