Skip to content

Fix Chrome’s new button style #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2017
Merged

Fix Chrome’s new button style #10

merged 1 commit into from
Nov 23, 2017

Conversation

charlesdemers
Copy link
Member

@charlesdemers charlesdemers commented Nov 23, 2017 •
edited
Loading

Chrome now adds border-radius by default on buttons, we remove it to avoid cross-browser layout disparity.

Edit: I regrouped button styles together at the same time

@remi remi mentioned this pull request Nov 23, 2017
Closed
@pboutin
Copy link
Contributor

pboutin commented Nov 23, 2017

See #11 :trollface:

simonprev
simonprev approved these changes Nov 23, 2017
View reviewed changes
Copy link
Member

@simonprev simonprev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📍 👍

@charlesdemers charlesdemers force-pushed the fix/remove-border-radius-on-buttons branch from 465b583 to 1d0ebe2 Compare November 23, 2017 15:17
@charlesdemers charlesdemers changed the title Fix Chrome’s new button style with border-radius Fix Chrome’s new button style Nov 23, 2017
pboutin
pboutin approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@pboutin pboutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto 👌

@charlesdemers charlesdemers merged commit 2d42458 into master Nov 23, 2017
@charlesdemers charlesdemers deleted the fix/remove-border-radius-on-buttons branch November 23, 2017 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonprev simonprev simonprev approved these changes

@pboutin pboutin pboutin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesdemers @pboutin @simonprev