No action needed: noService positional arg is already valid Java#93
Closed
Copilot wants to merge 1 commit intomm/service_alert_effect_no_servicefrom
Closed
No action needed: noService positional arg is already valid Java#93Copilot wants to merge 1 commit intomm/service_alert_effect_no_servicefrom
noService positional arg is already valid Java#93Copilot wants to merge 1 commit intomm/service_alert_effect_no_servicefrom
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on
No action needed: Mar 18, 2026
NO_SERVICE effect implementation in JavanoService positional arg is already valid Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bot suggested changing the
noServiceargument to use named parameter syntax (noService = noService), which is Kotlin-only and invalid in Java. The code already passesnoServiceas a correct positional argument — no change was required.GTFSRealTimeProvider.java:1130already uses plain positionalnoService, not named-parameter syntax💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.