Service update (alert/info) > add NO_SERVICE effect

[mmathieum]

Fix:

• Service Updates > add NO_SERVICE effect #91

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's ability to communicate service disruptions by introducing a dedicated 'no service' flag for service updates. This improvement is particularly beneficial for processing real-time data from GTFS-Realtime feeds, ensuring that users receive precise information about service availability. Alongside this, extensive debugging utilities for GTFS-Realtime data structures were refactored and expanded, which will aid in future development and maintenance.

Highlights

• New 'No Service' Indicator: Introduced a noService boolean field within the ServiceUpdate data class to explicitly mark service updates indicating a complete lack of service, enhancing clarity for users.
• GTFS-Realtime Integration: Integrated the NO_SERVICE effect from GTFS-Realtime alerts into the ServiceUpdate model, allowing real-time data feeds to accurately convey service disruptions.
• Enhanced Debugging for GTFS-Realtime: Significantly improved the toStringExt utility functions for various GTFS-Realtime objects (FeedMessage, Alert, TripUpdate, VehiclePosition, etc.) in Kotlin, providing more detailed and readable debug logs for easier troubleshooting and development.
• Provider Updates: Updated several transit providers (NextBus, OCTranspo, RTCQuebec, StmInfoApi, StmInfoSubway) to accommodate the new noService parameter in the ServiceUpdate constructor, ensuring compatibility across different data sources.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a noService boolean field to the ServiceUpdate class, including its constructor and a getter, to support GTFS-RealTime alerts indicating service disruptions. This new field is integrated into the ServiceUpdate's toString() method for better debugging. Corresponding updates were made across various data providers to correctly handle this new parameter, passing null where not applicable, and deriving it from GTFS-RT alerts. Additionally, the GtfsRealtimeExt.kt file underwent significant refactoring to standardize debug logging for GTFS-RT protobuf objects, introducing new toStringExt functions, optional field accessors, and custom string joining utilities (joinToStringList, joinToStringOption) to improve readability and consistency of log output. Review comments suggest improving log formatting in GTFSRealTimeProvider.java by using '|' as a separator instead of '-' for consistency and to prevent conflicts, explicitly naming the noService parameter in the ServiceUpdate constructor call for readability, and utilizing the new joinToStringOption() extension function in GtfsRealtimeExt.kt for consistent string formatting.