Skip to content

fix: add libc fields only to platforms that have libc#210

Merged
devongovett merged 1 commit intoparcel-bundler:masterfrom
yisibl:fix-libc
Jul 7, 2022
Merged

fix: add libc fields only to platforms that have libc#210
devongovett merged 1 commit intoparcel-bundler:masterfrom
yisibl:fix-libc

Conversation

@yisibl
Copy link
Contributor

@yisibl yisibl commented Jun 17, 2022

Add the libc field in a clearer and more explicit way.
After this PR, linux-gnueabihf also no longer adds the libc field.

Before

{
  "name": "@parcel/css-linux-arm-gnueabihf",
  "libc": [
    "gnueabihf"
  ]
}

Related PRs: #205, #208

@Brooooooklyn
Copy link
Contributor

@yisibl the libc field on linux-arm-gnueabihf should be glibc.

@yisibl
Copy link
Contributor Author

yisibl commented Jun 18, 2022

@Brooooooklyn Thanks! It looks like the napi-rs template needs to be updated as well?

@Brooooooklyn
Copy link
Contributor

@yisibl I don't think the libc field in linux-arm-gnueabihf is necessary, since there is only glibc runtime for linux-arm.

@yisibl
Copy link
Contributor Author

yisibl commented Jul 5, 2022

@devongovett PTAL, thanks!

@devongovett devongovett merged commit 60da2b5 into parcel-bundler:master Jul 7, 2022
@yisibl yisibl deleted the fix-libc branch July 7, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants