Skip to content

fix: add libc fields only to platforms that have libc #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 1 commit into from
Jul 7, 2022
Merged

fix: add libc fields only to platforms that have libc #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 42 additions & 20 deletions scripts/build-npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,37 @@ const fs = require('fs');
const pkg = require('../package.json');

const dir = `${__dirname}/..`;

// Add `libc` fields only to platforms that have libc(Standard C library).
const triples = [
'x86_64-apple-darwin',
'x86_64-unknown-linux-gnu',
'x86_64-pc-windows-msvc',
'aarch64-apple-darwin',
'aarch64-unknown-linux-gnu',
'armv7-unknown-linux-gnueabihf',
'aarch64-unknown-linux-musl',
'x86_64-unknown-linux-musl'
{
name: 'x86_64-apple-darwin',
},
{
name: 'x86_64-unknown-linux-gnu',
libc: 'glibc',
},
{
name: 'x86_64-pc-windows-msvc',
},
{
name: 'aarch64-apple-darwin',
},
{
name: 'aarch64-unknown-linux-gnu',
libc: 'glibc',
},
{
name: 'armv7-unknown-linux-gnueabihf',
},
{
name: 'aarch64-unknown-linux-musl',
libc: 'musl',
},
{
name: 'x86_64-unknown-linux-musl',
libc: 'musl',
},
];
const cpuToNodeArch = {
x86_64: 'x64',
Expand All @@ -24,9 +46,6 @@ const sysToNodePlatform = {
darwin: 'darwin',
windows: 'win32',
};
const abiToNodeLibc = {
gnu: 'glibc',
};

let optionalDependencies = {};
let cliOptionalDependencies = {};
Expand All @@ -36,7 +55,10 @@ try {
} catch (err) {}

for (let triple of triples) {
let [cpu, , os, abi] = triple.split('-');
// Add the libc field to package.json to avoid downloading both
// `gnu` and `musl` packages in Linux.
const libc = triple.libc;
let [cpu, , os, abi] = triple.name.split('-');
cpu = cpuToNodeArch[cpu] || cpu;
os = sysToNodePlatform[os] || os;

Expand All @@ -45,8 +67,8 @@ for (let triple of triples) {
t += '-' + abi;
}

buildNode(triple, cpu, os, abi, t);
buildCLI(triple, cpu, os, abi, t);
buildNode(triple.name, cpu, os, libc, t);
buildCLI(triple.name, cpu, os, libc, t);
}

pkg.optionalDependencies = optionalDependencies;
Expand All @@ -71,15 +93,15 @@ cliPkg.scripts = {
fs.writeFileSync(`${dir}/cli/package.json`, JSON.stringify(cliPkg, false, 2) + '\n');
fs.copyFileSync(`${dir}/README.md`, `${dir}/cli/README.md`);

function buildNode(triple, cpu, os, abi, t) {
function buildNode(triple, cpu, os, libc, t) {
let name = `parcel-css.${t}.node`;

let pkg2 = {...pkg};
pkg2.name += '-' + t;
pkg2.os = [os];
pkg2.cpu = [cpu];
if (abi && os !== "win32") {
pkg2.libc = [abiToNodeLibc[abi] || abi];
if (libc) {
pkg2.libc = [libc];
}
pkg2.main = name;
pkg2.files = [name];
Expand All @@ -101,15 +123,15 @@ function buildNode(triple, cpu, os, abi, t) {
fs.writeFileSync(`${dir}/npm/node-${t}/README.md`, `This is the ${triple} build of @parcel/css. See https://github.com/parcel-bundler/parcel-css for details.`);
}

function buildCLI(triple, cpu, os, abi, t) {
function buildCLI(triple, cpu, os, libc, t) {
let binary = os === 'win32' ? 'parcel_css.exe' : 'parcel_css';
let pkg2 = {...pkg};
pkg2.name += '-cli-' + t;
pkg2.os = [os];
pkg2.cpu = [cpu];
pkg2.files = [binary];
if (abi && os !== "win32") {
pkg2.libc = [abiToNodeLibc[abi] || abi];
if (libc) {
pkg2.libc = [libc];
}
delete pkg2.main;
delete pkg2.napi;
Expand Down