fix: support importing via ES modules#220
Closed
aminya wants to merge 2 commits intoparcel-bundler:masterfrom
Closed
fix: support importing via ES modules#220aminya wants to merge 2 commits intoparcel-bundler:masterfrom
aminya wants to merge 2 commits intoparcel-bundler:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
devongovett
reviewed
Jul 3, 2022
| } | ||
| } | ||
|
|
||
| export default default_export; |
Member
There was a problem hiding this comment.
Maybe some of the above logic could be deduplicated with the index.js file?
import {createRequire} from 'module';
const require = createRequire(import.meta.url);
export default require('./index.js');
Author
There was a problem hiding this comment.
What about the reverse? Generating the old commonjs file from the mjs file?
Member
There was a problem hiding this comment.
I guess it could be, but it would just be CommonJS to load the native module regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using parcel-css from ES modules. Some build tools (e.g. Astro) require ES modules.