Custom at rules nesting issues #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsak-shell
commented
Jul 27, 2021
| let clone = rule.clone({ nodes: [] }) | ||
| for (let child of children) { | ||
| clone.append(child) | ||
| function createFnAtruleChilds (bubble) { |
There was a problem hiding this comment.
Just a wrapper - currying to have bubble available in the scope.
bsak-shell
commented
Jul 27, 2021
| } else if (child.type === 'rule' && bubbling) { | ||
| child.selectors = selectors(rule, child) | ||
| } else if (child.type === 'atrule') { | ||
| if (child.nodes && bubble[child.name]) { |
There was a problem hiding this comment.
Only bubble if has children and actually should bubble, otherwise push as a "casual" child node.
|
Sorry, I have a busy week and this PR requires a lot of review (because of complex nature of transformation). I will try to review it later. Feel free to ping me again next week. |
|
@ai Sure, thanks for reply :) |
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136, and likely: #81, #124, #123.