Skip to content

Custom at rules nesting issues #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ai merged 2 commits into from
Jul 28, 2021
+36 −22
Merged

Custom at rules nesting issues #137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c0b6b
Fix childless custom at-rules nested in bubbling at-rules
bsak-shell Jul 23, 2021
91fc42a
Fix non-bubbling custom at-rules with children, nested in bubbling at…
bsak-shell Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix childless custom at-rules nested in bubbling at-rules
  • Loading branch information
@bsak-shell
bsak-shell committed Jul 27, 2021
commit c3c0b6b6eee9c84804f69e406670d229a1e427ce
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ function atruleChilds (rule, atrule, bubbling) {
} else if (child.type === 'rule' && bubbling) {
child.selectors = selectors(rule, child)
} else if (child.type === 'atrule') {
atruleChilds(rule, child, bubbling)
if (child.nodes) {
atruleChilds(rule, child, bubbling)
} else {
children.push(child)
}
}
})
if (bubbling) {
Expand Down
4 changes: 2 additions & 2 deletions index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ it('unwraps at-rules with interleaved properties', () => {

it('do not move custom at-rules', () => {
run(
'.one { @mixin test; } .two { @phone { color: black } }',
'.one { @mixin test; } @phone { .two { color: black } }',
'.one { @mixin test; } .two { @media screen { @mixin test; } } .three { @phone { color: black } }',
'.one { @mixin test; } @media screen { .two { @mixin test } } @phone { .three { color: black } }',
{ bubble: ['phone'] }
)
})
Expand Down