Specify font-family for buttons without Helvetica to fix alignment #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Helvetica for button fonts causes some weird vertical alignment issues in Chrome OSX (FireFox and Safari are fine) for form elements such as `<input>` and `<button>`, but not for other elements such as `<a>`. Their alignment is especially noticeable if you place them next to each other. Removing Helvetica from the fonts list for these elements causes the styling to fall back to using Arial, which fixes the issue. At the button's font sizes, it's hard to tell the difference between the two types anyway, and arguably even (barely) improves legibility.
|
We won't be removing Helvetica from the stack. This is a Chrome bug that's already fixed in the latest Canary builds. Should land in stable soon. Thanks though! |
|
Cool, makes sense to wait for that. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Helvetica for button fonts causes some weird vertical alignment issues in Chrome OSX (Firefox and Safari are fine) for form elements such as
<input>and<button>, but not for other elements such as<a>. Their alignment is especially noticeable if you place them next to each other (see before/after image).Removing Helvetica from the fonts list for these elements causes the styling to fall back to using Arial, which fixes the issue. At the button's font sizes, it's hard to tell the difference between the two
types anyway, and arguably even (barely) improves legibility.
Before and after the fix, both in Primer and on GitHub: