Skip to content

Specify font-family for buttons without Helvetica to fix alignment #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Specify font-family for buttons without Helvetica to fix alignment #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions css/.primer-stats.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
### css/primer.css

- **Total Stylesheets:** 1
- **Total Stylesheet Size:** 30812
- **Total Stylesheet Size:** 30822
- **Total Media Queries:** 1
- **Total Rules:** 404
- **Selectors Per Rule:** 1.4405940594059405
Expand All @@ -18,6 +18,6 @@
- **Top Selector Specificity Selector:** .fullscreen-overlay-enabled.dark-theme .tooltipped .tooltipped-s:before
- **Total Id Selectors:** 0
- **Total Identifiers:** 1249
- **Total Declarations:** 1003
- **Total Declarations:** 1004
- **Total Unique Colors:** 79
- **Total Important Keywords:** 1
2 changes: 1 addition & 1 deletion css/primer.css
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion scss/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ input,
select,
textarea,
button {
font: #{$body-font-size}/1.4 $body-font;
font: #{$body-font-size}/1.4 $button-font;
font-family: inherit;
}

body {
Expand Down
1 change: 1 addition & 0 deletions scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ $brand-purple: #6e5494 !default;

// Font stack
$body-font: Helvetica, arial, nimbussansl, liberationsans, freesans, clean, sans-serif, "Segoe UI Emoji", "Segoe UI Symbol" !default;
$button-font: arial, nimbussansl, liberationsans, freesans, clean, sans-serif, "Segoe UI Emoji", "Segoe UI Symbol" !default;

// The base body size
$body-font-size: 13px !default;
Expand Down