Conversation
HISTORY.md
Outdated
There was a problem hiding this comment.
Nit-pick: I think we should make all HISTORY entries passed tense. "Added" instead of "Add". :)
|
@tilomitra I'm curious to know why you didn't break this out into it's own feature file, like we do for paginator? |
Mostly because I see button groups as being very closely tied to buttons, whereas paginator has a completely different look and feel compared to I don't see button groups and buttons to be two separate components. A button-group is merely a collection of buttons. |
Okay cool, sounds good. |
|
@tilomitra can you address the remaining issues for this PR, so we can do a final pass then get this merged? |
|
Me would second including button grouping with the default buttons. (balanced by removing paginators, Issue #248) Where Button groups are very usefull, maybe most of the time something like "pure-button-pressed" may also be wanted to display the current selection. (Similar to menu selection, but not to disabled buttons.) |
|
Will this be part of 0.50? If not, when will it get merged? |
This is will not be in 0.5.0. |
|
Button Group reminds me of what Apple calls a "Segmented Control", which itself is often used to control what is now commonly known as a tab-view. As these are clearly opinionated components, I suspect they will not be included in Pure, but perhaps rolled into some future component library project. |
|
CLA is valid! |
|
If anyone is following this, I will try to get this feature into the next release, Pure 0.6. I just need to test it, check the samples, and remove the bolding for old IE. |
|
Thank you very much, that is perfect! |
|
Given this PR is old and cannot be merged. I've replaced it with #621. |
This PR adds horizontal button groups to pure, thereby fixing #126.
Why we need button groups
I think button groups are a good way of grouping multiple buttons together to give them some sense of context. This can be useful in a variety of websites.
How it works
The button groups are wrapped in an element with the
.pure-button-groupclassname. This element inherits the styles from.pure-gto collapse the whitespace within it. The.pure-buttonelements within this reset the letter and word-spacing, similar to.pure-u.How it looks
Test Coverage