Skip to content

Add Button Groups to Pure#145

Closed
tilomitra wants to merge 4 commits intopure-css:masterfrom
tilomitra:button-groups
Closed

Add Button Groups to Pure#145
tilomitra wants to merge 4 commits intopure-css:masterfrom
tilomitra:button-groups

Conversation

@tilomitra
Copy link
Contributor

This PR adds horizontal button groups to pure, thereby fixing #126.

Why we need button groups

I think button groups are a good way of grouping multiple buttons together to give them some sense of context. This can be useful in a variety of websites.

How it works

The button groups are wrapped in an element with the .pure-button-group classname. This element inherits the styles from .pure-g to collapse the whitespace within it. The .pure-button elements within this reset the letter and word-spacing, similar to .pure-u.

How it looks

button groups

Test Coverage

  • IE7+
  • Chrome
  • Safari
  • FF
  • iOS6
  • Android 4.0.x.

HISTORY.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick: I think we should make all HISTORY entries passed tense. "Added" instead of "Add". :)

@ericf
Copy link
Collaborator

ericf commented Jul 23, 2013

@tilomitra I'm curious to know why you didn't break this out into it's own feature file, like we do for paginator?

@tilomitra
Copy link
Contributor Author

I'm curious to know why you didn't break this out into it's own feature file, like we do for paginator?

Mostly because I see button groups as being very closely tied to buttons, whereas paginator has a completely different look and feel compared to .pure-menu, and is a separate "component". The only thing in common between paginator and menus is that they are both <li> based.

I don't see button groups and buttons to be two separate components. A button-group is merely a collection of buttons.

@ericf
Copy link
Collaborator

ericf commented Jul 23, 2013

I don't see button groups and buttons to be two separate components. A button-group is merely a collection of buttons.

Okay cool, sounds good.

@ericf
Copy link
Collaborator

ericf commented Nov 25, 2013

@tilomitra can you address the remaining issues for this PR, so we can do a final pass then get this merged?

@testbird
Copy link

Me would second including button grouping with the default buttons. (balanced by removing paginators, Issue #248)

Where Button groups are very usefull, maybe most of the time something like "pure-button-pressed" may also be wanted to display the current selection. (Similar to menu selection, but not to disabled buttons.)
Maybe a generic alternative could also be something like "well" (see http://cardinalcss.com/#layout) to make anything appear sunken.

@testbird testbird mentioned this pull request Nov 29, 2013
@sethlivingston
Copy link

Will this be part of 0.50? If not, when will it get merged?

@ericf
Copy link
Collaborator

ericf commented May 27, 2014

Will this be part of 0.50? If not, when will it get merged?

This is will not be in 0.5.0.

@jamesalley
Copy link
Contributor

Button Group reminds me of what Apple calls a "Segmented Control", which itself is often used to control what is now commonly known as a tab-view. As these are clearly opinionated components, I suspect they will not be included in Pure, but perhaps rolled into some future component library project.

@yahoocla
Copy link

CLA is valid!

@jamesalley
Copy link
Contributor

If anyone is following this, I will try to get this feature into the next release, Pure 0.6. I just need to test it, check the samples, and remove the bolding for old IE.

@testbird
Copy link

Thank you very much, that is perfect!

@redonkulus
Copy link
Contributor

redonkulus commented Dec 28, 2016

Given this PR is old and cannot be merged. I've replaced it with #621.

@redonkulus redonkulus closed this Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants