-
Notifications
You must be signed in to change notification settings - Fork 2.4k
IE8+ only edition of Pure with W3C validation fixes #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
662a0c5
2963cdc
cd038f3
2d772f6
e6a3665
3db8ab4
182842f
f6b72c0
cc56a16
aed3bc9
e87102a
1819778
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../node_modules |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,6 @@ | |
|
|
||
| .pure-g { | ||
| letter-spacing: -0.31em; /* Webkit: collapse white-space between units */ | ||
| *letter-spacing: normal; /* reset IE < 8 */ | ||
| *word-spacing: -0.43em; /* IE < 8: collapse white-space between units */ | ||
| text-rendering: optimizespeed; /* Webkit: fixes text-rendering: optimizeLegibility */ | ||
|
|
||
| /* | ||
| Sets the font stack to fonts known to work properly with the above letter | ||
|
|
@@ -24,26 +21,22 @@ | |
| */ | ||
| font-family: FreeSans, Arimo, "Droid Sans", Helvetica, Arial, sans-serif; | ||
|
|
||
| /* | ||
| Use flexbox when possible to avoid `letter-spacing` side-effects. | ||
|
|
||
| NOTE: Firefox (as of 25) does not currently support flex-wrap, so the | ||
| `-moz-` prefix version is omitted. | ||
| */ | ||
|
|
||
| display: -webkit-flex; | ||
| -webkit-flex-flow: row wrap; | ||
| /* Use flexbox when possible to avoid `letter-spacing` side-effects. */ | ||
| display: flex; | ||
| flex-flow: row wrap; | ||
|
|
||
| /* IE10 uses display: flexbox */ | ||
| display: -ms-flexbox; | ||
| -ms-flex-flow: row wrap; | ||
|
|
||
| /* Prevents distributing space between rows */ | ||
| -ms-align-content: flex-start; | ||
| -webkit-align-content: flex-start; | ||
| align-content: flex-start; | ||
| align-content: flex-start; | ||
| } | ||
|
|
||
| /* IE10 display: -ms-flexbox (and display: flex in IE 11) does not work inside a table; fall back to block and rely on font hack */ | ||
| @media all and (-ms-high-contrast: none), (-ms-high-contrast: active) { | ||
| table .pure-g { | ||
| display: block; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| /* Opera as of 12 on Windows needs word-spacing. | ||
| The ".opera-only" selector is used to prevent actual prefocus styling | ||
| and is not required in markup. | ||
|
|
@@ -55,12 +48,9 @@ | |
|
|
||
| .pure-u { | ||
| display: inline-block; | ||
| *display: inline; /* IE < 8: fake inline-block */ | ||
| zoom: 1; | ||
| letter-spacing: normal; | ||
| word-spacing: normal; | ||
| vertical-align: top; | ||
| text-rendering: auto; | ||
| vertical-align: bottom; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what was the reason for changing this one?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is #539 (which I replicated in testing) & removing text-rendering as text-rendering isn't W3C valid, even at CSS3 spec.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why would
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
|
|
||
| /* | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing IE specific calls less than 8. Text rendering is non W3C & should really be done outside the core from where I stand.