IE8+ only edition of Pure with W3C validation fixes#615
IE8+ only edition of Pure with W3C validation fixes#615absalomedia wants to merge 12 commits intopure-css:masterfrom absalomedia:IE8
Conversation
|
CLA is valid! |
|
@absalomedia the commit history is a bit hard as its a combination of yours and @lkraav, while also reverting some changes made previously. If we want to keep the attribution for both of you, maybe we can rebase the commits down to 1 commit for each of you. Plus, it looks like there are merge conflicts as well that would need to be resolved. I'd also like to remove the bower changes to a separate PR later on. |
| letter-spacing: -0.31em; /* Webkit: collapse white-space between units */ | ||
| *letter-spacing: normal; /* reset IE < 8 */ | ||
| *word-spacing: -0.43em; /* IE < 8: collapse white-space between units */ | ||
| text-rendering: optimizespeed; /* Webkit: fixes text-rendering: optimizeLegibility */ |
There was a problem hiding this comment.
Removing IE specific calls less than 8. Text rendering is non W3C & should really be done outside the core from where I stand.
| word-spacing: normal; | ||
| vertical-align: top; | ||
| text-rendering: auto; | ||
| vertical-align: bottom; |
There was a problem hiding this comment.
what was the reason for changing this one?
There was a problem hiding this comment.
This is #539 (which I replicated in testing) & removing text-rendering as text-rendering isn't W3C valid, even at CSS3 spec.
There was a problem hiding this comment.
Why would vertical-align: top go to bottom though? It isn't connected to text-rendering is it?
|
Lets open a new PR that only includes the changes to remove < IE 8, then the maintainers can evaluate if and when to incorporate this. |
IE8 rollup fixes & W3C validation fixes including @lkraav work on #551.
Addresses: #575 & #576
Includes all issues resolved on #551 as well as: #381, #480, #504, #539, #583, #584