Incorporate pull request rails/jquery-ujs#377#160
Closed
marnen wants to merge 1 commit intorails:masterfrom
Closed
Incorporate pull request rails/jquery-ujs#377#160marnen wants to merge 1 commit intorails:masterfrom
marnen wants to merge 1 commit intorails:masterfrom
Conversation
Member
|
Thank you for the PR. We will incorporate as soon it is merged there. |
Author
|
That works. I wasn't sure how to handle a pull request across 2 repositories. |
Author
|
@rafaelfranca Now that rails/jquery-ujs#377 is merged, should I reopen this? |
Contributor
|
@marnen we do not accept PRs updating the vendored JavaScript files. The jquery-ujs change will be incorporated here once we cut a new release of the jquery-ujs project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rails/jquery-ujs#377 for full discussion; this fixes handling of form inputs when the
formattribute instead of a<form>element is used.