Form inputs can use the form attribute too#377
Merged
lucasmazza merged 2 commits intorails:masterfrom Jul 8, 2014
Merged
Conversation
This was referenced Jun 9, 2014
Contributor
Author
|
Do you need anything further to merge this request? |
Member
|
I think we would need tests. |
Contributor
Author
|
@rafaelfranca I actually didn't realize this project even had a test suite, and I wish you'd told me sooner that you needed tests. Let me see what I can do... |
Contributor
Author
|
@rafaelfranca I added a test case. Is this suitable, or do you need more? |
Member
|
@lucasmazza WDYT? |
lucasmazza
added a commit
that referenced
this pull request
Jul 8, 2014
Form inputs can use the form attribute too
Contributor
Author
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #376 by ensuring that form inputs are selected even if they're not within a
<form>element, as long as they refer to one with theformattribute.