Skip to content

jQuery Transit doesn't work with jQuery 1.8.2 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emersion wants to merge 1 commit into from
Closed

jQuery Transit doesn't work with jQuery 1.8.2 #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions jquery.transit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
*
* http://ricostacruz.com/jquery.transit
* http://github.com/rstacruz/jquery.transit
*
* Reviewed by Simon SER to work with jQuery 1.8.2.
*
*/

(function($) {
Expand Down Expand Up @@ -603,12 +606,12 @@

$.cssHooks[prop] = {
get: function(elem) {
var t = $(elem).css('transform') || new Transform();
var t = ($(elem).css('transform') && $(elem).css('transform') != 'none') ? $(elem).css('transform') : new Transform();
Copy link

@miketaylr miketaylr Oct 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to "cache" a reference to $(elem).css('transform') so you don't have to call $.fn.css 2 or 3 times.

Copy link
Author

@emersion emersion Oct 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, here's a good fix : #77

return t.get(prop);
},

set: function(elem, value) {
var t = $(elem).css('transform') || new Transform();
var t = ($(elem).css('transform') && $(elem).css('transform') != 'none') ? $(elem).css('transform') : new Transform();
t.setFromString(prop, value);

$(elem).css({ transform: t });
Expand Down