Skip to content

Build with serde support on CI #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonSapin opened this issue Aug 13, 2015 · 2 comments
Closed

Build with serde support on CI #86

SimonSapin opened this issue Aug 13, 2015 · 2 comments

Comments

@SimonSapin
Copy link
Member

Do something similar to #85 (comment) for every optional features.
@mylainos
Copy link

So we should add something like this to .travis.yml at line 13 ?

  - ([ $TRAVIS_RUST_VERSION != nightly ] || cargo test --features serde-serialization)

@SimonSapin
Copy link
Member Author

Indeed! Thanks for reminding me.

SimonSapin added a commit that referenced this issue Jan 4, 2016
@SimonSapin
Revert "Test with serde on Travis. Fix #86"
b844896 
This reverts commit a8f3529.

Nightly builds like https://travis-ci.org/servo/rust-cssparser/jobs/100079015
regularly get broken because on of serde’s dependencies needs to be updated
for changes in unstable Rust APIs.

This has so far never been an issue in cssparer itself, which only has
`#[derive]` attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonSapin @mylainos