Skip to content

Conversation

@notriddle
Copy link
Contributor

Part of servo/heapsize#5.

Review on Reviewable

@SimonSapin
Copy link
Member

So that this code is built on CI, please add a line in the script section of .travis.yml that is something like this (untested):

   - ([ $TRAVIS_RUST_VERSION != nightly ] || cargo test --features heap_size)

src/lib.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use this over deriving the trait on the types?

@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 9e84a9f has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 9e84a9f with merge 440a30f...

bors-servo pushed a commit that referenced this pull request Aug 13, 2015
Add HeapSizeOf support.

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/85)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit 9e84a9f into servo:master Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants